Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Linix oneliner to download latest tflint #435

Merged
merged 1 commit into from
Sep 15, 2019

Conversation

abitrolly
Copy link
Contributor

No description provided.

@wata727
Copy link
Member

wata727 commented Sep 14, 2019

Why we need the oneliner script? Is install_linux.sh not enough?
I think it would be better to keep the README as simple as possible...

@abitrolly
Copy link
Contributor Author

Onliner has an advantage that it can be copy-pasted into terminal and recorded in shell history in case the program needs to be updated again. With install_linux.sh I need to keep it around or download every time.

@wata727
Copy link
Member

wata727 commented Sep 15, 2019

OK, it makes sense. How about the following oneliner script instead?

$ curl https://raw.githubusercontent.com/wata727/tflint/master/install_linux.sh | sh

@abitrolly
Copy link
Contributor Author

I personally still prefer to understand what a script does. Nevertheless that's also a good solution for my user story.

@wata727 wata727 merged commit cc0e469 into terraform-linters:master Sep 15, 2019
@wata727
Copy link
Member

wata727 commented Sep 15, 2019

I personally prefer not this oneliner, but I respect your opinion. If we get any other feedback, I will reconsider it again.

@abitrolly abitrolly deleted the patch-1 branch September 16, 2019 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants