When checking if a source is pinned, allow for Mercurial/Bitbucket #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bitbucket repos can be Git or Mercurial (for now, at least!), and Terraform can use either of them as a source. If you were using a Mercurial Bitbucket repo as your module source, it would be reported as unpinned -- even if you were pinning to a non-default Mercurial revision.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bitbucket repos can be Git or Mercurial (for now, at least!), and Terraform can use either of them as a source. If you were using a Mercurial Bitbucket repo as your module source, it would be reported as unpinned – even if you were pinning to a non-default Mercurial revision.
Spotted while working on #513.