Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds support for aws_autoscaling_group tag blocks and tags attributes #670

Merged
merged 3 commits into from Mar 21, 2020
Merged

Adds support for aws_autoscaling_group tag blocks and tags attributes #670

merged 3 commits into from Mar 21, 2020

Conversation

bwhaley
Copy link
Contributor

@bwhaley bwhaley commented Mar 16, 2020

Fixes #662

wata727
wata727 reviewed Mar 17, 2020
View reviewed changes
Copy link
Member

@wata727 wata727 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bwhaley! I left some comments.

rules/awsrules/aws_resource_missing_tags.go Outdated Show resolved Hide resolved
rules/awsrules/aws_resource_missing_tags.go Outdated Show resolved Hide resolved
rules/awsrules/aws_resource_missing_tags.go Outdated Show resolved Hide resolved
tflint/runner.go

err = gocty.FromCtyValue(val, ret)
// EvaluateExprType is like EvaluateExpr, but also accepts a known cty.Type to pass to EvalExpr
func (r *Runner) EvaluateExprType(expr hcl.Expression, ret interface{}, wantType cty.Type) error {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

It will be great if the two APIs are integrated in the future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I didn't love this solution, but fixing it seemed like a lot of refactoring which didn't seem prudent.

rules/awsrules/aws_resource_missing_tags.go Outdated Show resolved Hide resolved
@bwhaley
Copy link
Contributor Author

bwhaley commented Mar 18, 2020

Thanks for the review! I believe I've incorporated all the feedback in d583da6. Let me know if any other changes are needed.

@wata727 wata727 merged commit 99035e1 into terraform-linters:master Mar 21, 2020
@wata727
Copy link
Member

wata727 commented Mar 21, 2020

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wata727 wata727 wata727 left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws_resource_missing_tags rule flags tagged resource aws_autoscaling_group
2 participants
@bwhaley @wata727