Add dash checks for data sources and modules #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add `terraform_dash_in_data_source_name` rule, which checks for dashes in data source names * Add `terraform_dash_in_module_name` rule, which checks for dashes in module declarations
wata727
reviewed
Mar 22, 2020
| ## Example | ||
|
|
||
| ```hcl | ||
| module dash-name" { |
There was a problem hiding this comment.
😅
Suggested change
| module dash-name" { | |
| module "dash-name" { |
| @@ -0,0 +1,34 @@ | |||
| # terraform_dash_in_data_source_name | |||
There was a problem hiding this comment.
It is good to add links to these rules to the documentation index:
https://github.com/terraform-linters/tflint/blob/b18fd7e6fb8e6381b1307ac5bab16ee08dbec78c/docs/rules/README.md
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for this awesome project!
terraform_dash_in_data_source_namerule, which checks for dashesin data source names
terraform_dash_in_module_namerule, which checks for dashes inmodule declarations