Build EvalContext as the root module #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wata727
force-pushed
the
build_eval_context_with_root_module
branch
from
fc9103a
to
737490a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #733
Closes #736
I found that I was making a big mistake in building the eval context. According to the documentation, the
terraform.Evaluator'sConfigfield should always be the root module, not the individual modules.https://github.com/hashicorp/terraform/blob/v0.12.24/terraform/evaluate.go#L34-L35
The current implementation builds an Evaluator for each module and each module's evaluation context is treated as the root module. So, the values of
path.rootandpath.modulewill always be the same.This PR makes
path.rootto be evaluated correctly by building Evaluator and EvalContext for the root module.