add terraform_deprecated_index (disallows foo.0) #784
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a rule that disallows the legacy dot/attribute syntax for accessing indexes in a list. This syntax was officially recommended in v0.11:
https://www.terraform.io/docs/configuration-0-11/interpolation.html
And because most official providers still use 0.11 syntax in their docs, I still see this used quite a bit:
https://www.terraform.io/docs/providers/kubernetes/r/service_account.html
https://www.terraform.io/docs/providers/aws/r/acm_certificate_validation.html
It is no longer present in the 0.12 documentation and didn't even make the HCL spec:
hashicorp/hcl#305