Do not walk resource attributes if the resource is not created #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wata727
force-pushed
the
skip_walking_when_not_created
branch
from
7d18947
to
e38121d
Compare
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #778
If
countis zero orfor_eachis empty, Terraform will not evaluate the attributes of that resource. On the other hand, TFLint tries to evaluate the expression of any attribute regardless of the meta-arguments. As a result, TFLint sometimes reports errors that are not reported by Terraform.To avoid this problem, try to ignore resources that may not be evaluated when walking resource attributes and blocks. You may want to walk all the resources, whether they are evaluated or not, but I think we need to provide each API in that case.