Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow no extensions on windows #789

Merged
merged 1 commit into from Jun 6, 2020
Merged

Allow no extensions on windows #789

merged 1 commit into from Jun 6, 2020

Conversation

jpreese
Copy link
Member

@jpreese jpreese commented Jun 6, 2020

Windows does not require the .exe extension and this was causing some confusing when trying to create the tflint binary using -o with go build.

@jpreese jpreese requested a review from wata727 June 6, 2020 02:09
@jpreese
Copy link
Member Author

jpreese commented Jun 6, 2020

For kicks and giggles I tried tagging this on my own fork and pulled it in there to see if it truly solved the issue-- but I'm seeing the same behavior which was quite unexpected. Going to evaluate some more.

@jpreese jpreese closed this Jun 6, 2020
@jpreese
Copy link
Member Author

jpreese commented Jun 6, 2020

Don't code tired friends, this is fine. Wasn't even testing against these changes.

@jpreese jpreese reopened this Jun 6, 2020
wata727
wata727 approved these changes Jun 6, 2020
View reviewed changes
Copy link
Member

@wata727 wata727 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wata727 wata727 merged commit df03d4b into terraform-linters:master Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wata727 wata727 wata727 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jpreese @wata727