Support custom formats in terraform_naming_convention rule #860
Conversation
|
Thanks! May take me a couple days but I will review this this week. |
| @@ -77,91 +99,68 @@ func (r *TerraformNamingConventionRule) Check(runner *tflint.Runner) error { | |||
| return fmt.Errorf("Invalid default configuration: %v", err) | |||
| } | |||
|
|
|||
| if err := r.checkDataBlocks(runner, &config, defaultNameValidator); err != nil { | |||
| return err | |||
| var dataTargets, localTargets, moduleTargets, outputTargets, resourceTargets, variableTargets []RuleTarget | |||
There was a problem hiding this comment.
Avoid collecting data into new slices like this. Iterate directly over the maps that Terraform has already allocated for each block type. 👍 to eliminating r.checkLocalValues and similar heavily duplicated methods, but it should be possible to do so without copying data ahead of time.
There was a problem hiding this comment.
@bendrucker I made the corrections to iterate the maps directly. Hope that's better now.
|
Thanks! Will give this a final look later today and make any small adjustments as needed. Appreciate the improvements here, eventually I'll look to cut this rule down to just the default (snake) or fully described custom formats. |
|
Forgot to come back to this, finishing up now |
|
The code for this rule could definitely use some love, appreciate you working through to add this feature. I spent 20 mins starting to refactor and rename (4x `get*NameValidator methods 😓) but it was quickly turning into a full rewrite. Since this is working, didn't want to continue to hold it up. |
|
Thanks a lot @bendrucker. I hope to make more contribution in the future. |
Closes #857