Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): bump go to v1.15 #871

Merged
merged 4 commits into from
Aug 27, 2020
Merged

chore(deps): bump go to v1.15 #871

merged 4 commits into from
Aug 27, 2020

Conversation

chenrui333
Copy link
Contributor

No description provided.

@bendrucker
Copy link
Member

Build is failing:

  • golang:1.15-alpine3.11 is not a valid image
  • The generated code is slightly different, so run make code to update that

@bendrucker bendrucker merged commit 6533444 into terraform-linters:master Aug 27, 2020
@chenrui333
Copy link
Contributor Author

Thanks @bendrucker!!

@chenrui333
Copy link
Contributor Author

I did keep running into api-2.json reference issue, not sure how did you resolve it?

$ make code
go generate ./...
panic: open aws-sdk-go/models/apis/acm-pca/2017-08-22/api-2.json: no such file or directory

@bendrucker
Copy link
Member

Perhaps your submodule is out of date? git submodule update --init should address that.

@chenrui333
Copy link
Contributor Author

aha, that makes more sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chenrui333 @bendrucker