Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin: Clarify plugin's incompatible API version errors #885

Merged
merged 1 commit into from Aug 23, 2020

Conversation

wata727
Copy link
Member

@wata727 wata727 commented Aug 22, 2020

Fixes #879

When lacking compatibility of API between TFLint core and plugin due to the update of tflint-plugin-sdk, the error message returned from go-plugin is output as it is:

$ tflint
Failed to initialize plugins. An error occurred:

Error: Incompatible API version with plugin. Plugin version: 3, Client versions: [4]

However, it is not clear. So this PR changes the error message when it contains "Incompatible API version":

$ tflint
Failed to initialize plugins. An error occurred:

Error: Incompatible API version with plugin "azurerm". Plugin version: 3, TFLint versions: [4]

Copy link
Member

@bendrucker bendrucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to have tests around this, but definite 👍🏻 to the result!

@wata727
Copy link
Member Author

wata727 commented Aug 23, 2020

Yeah, I would like to write a test too, but it seemed a bit difficult to have two different versions of tflint-plugin-sdk in Go modules...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Clarify tflint plugin errors?
2 participants