Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for clouds.yaml #154

Merged
merged 2 commits into from
Nov 21, 2017

Conversation

jtopjian
Copy link
Contributor

For #122

@mcanevet Thank you for your patience with this. Please let me know what you think and if you see room for improvement.

@mcanevet
Copy link
Contributor

@jtopjian Thanks a lot for this work.
I get "You must provide exactly one of DomainID or DomainName to authenticate by Username" with a clouds.yaml file containing:

clouds:
  test:
    auth:
      auth_url: https://cloud.example.com/v3
      username: foo
      password: bar
      project_id: deadbeef
      project_name: test
      user_domain_name: example
    region_name: regionOne
    interface: public
    identity_api_version: 3

Any idea?

@mcanevet
Copy link
Contributor

It works if I add domain_name in the clouds.yaml file, but somehow I don't have this key set when I download the clouds.yaml file for horizon...
Are you sure it shouldn't be user_domain_name and user_domain_id instead of domain_name and domain_id here: https://github.com/gophercloud/utils/blob/master/openstack/clientconfig/results.go#L28-L29 ?

@mcanevet
Copy link
Contributor

@jtopjian I think it should be like that : gophercloud/utils#3

This commit adds initial support for clouds.yaml files. This allows
the user to specify an entry in clouds.yaml which will provide all
authentication requirements for the openstack cloud.
@jtopjian
Copy link
Contributor Author

@mcanevet Thank you for verifying this and for fixing up gophercloud/utils. I've rebased the vendor commit with your addition. When you have time, let me know how it's working now :)

@mcanevet
Copy link
Contributor

@jtopjian works fine for me now.
Thanks a lot for this great work.

@jtopjian
Copy link
Contributor Author

@mcanevet Perfect - thank you for testing!

@fatmcgav @catsby ping for review on this.

Copy link

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jtopjian
Copy link
Contributor Author

@catsby Thank you!

@mcanevet Thank you very much for your patience with this feature. As well, thank you again for testing it.

@jtopjian jtopjian merged commit 1017aa0 into terraform-provider-openstack:master Nov 21, 2017
@mcanevet
Copy link
Contributor

@jtopjian thanks a lot for implementing this.
Time for a new release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants