Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LBaaS v2: Lower Delays for Load Balancer Resources #297

Merged

Conversation

jtopjian
Copy link
Contributor

This commit lowers the delays for the load balancer resources
while waiting for a certain state. For the LoadBalancer resource
in particular, the delay is set to 0.

Fixes #295

I tested setting all delays to 0 and everything worked, but I want to be cautious here. #295 specifically requested the load balancer delay to be set to 0, so I've implemented that. For everything else, I've lowered it to 1 second.

This commit lowers the delays for the load balancer resources
while waiting for a certain state. For the LoadBalancer resource
in particular, the delay is set to 0.
@jtopjian jtopjian requested a review from fatmcgav April 25, 2018 02:33
@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 25, 2018

Build succeeded.

@jtopjian
Copy link
Contributor Author

recheck lbaas

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 26, 2018

Build failed.

@jtopjian
Copy link
Contributor Author

recheck lbaas

@jtopjian
Copy link
Contributor Author

I've tested this already outside of OpenLab and it works.

I'm now seeing if the OpenLab lbaas checks are working and it looks like there might be some problem. OpenLab isn't making it to the point of running the tests, so any failure here is ignorable.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 26, 2018

Build failed.

Copy link
Contributor

@fatmcgav fatmcgav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtopjian jtopjian merged commit 510b51a into terraform-provider-openstack:master May 8, 2018
@jtopjian jtopjian deleted the lbaasv2-delays branch October 22, 2018 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants