Manila: add share acl resource #526

kayrus · 2018-12-14T20:42:33Z

Part of #502

theopenlab-ci · 2018-12-14T22:51:44Z

Build failed.

terraform-provider-openstack-unittest : SUCCESS in 2m 43s
terraform-provider-openstack-acceptance-test : FAILURE in 2h 08m 03s

mrhillsman · 2018-12-16T17:40:59Z

recheck

theopenlab-ci · 2018-12-16T20:01:38Z

Build failed.

terraform-provider-openstack-unittest : SUCCESS in 2m 26s
terraform-provider-openstack-acceptance-test : FAILURE in 2h 19m 52s

theopenlab-ci · 2018-12-17T14:38:21Z

Build failed.

terraform-provider-openstack-unittest : SUCCESS in 2m 21s
terraform-provider-openstack-acceptance-test : FAILURE in 2h 27m 25s

theopenlab-ci · 2018-12-17T18:43:10Z

Build failed.

terraform-provider-openstack-unittest : SUCCESS in 2m 27s
terraform-provider-openstack-acceptance-test : FAILURE in 2h 01m 43s

kayrus · 2018-12-20T00:08:08Z

I'm thinking about merging ACL into the share resource as a list of maps, like in aws security groups. Does it make sense?

jtopjian · 2018-12-20T01:31:58Z

What's the reasoning behind merging the two?

In general, I would advise against it. If the ACL is part of the share resource, then a user will never be able to decouple an ACL from a share to do things such as use count.

aws_security_group looks very similar to openstack_compute_secgroup_v2 which caused a lot of limitations and problems. Thankfully, the Compute Security Group API became deprecated, so we could consider it a legacy resource and design openstack_networking_secgroup_v2 and openstack_networking_secgroup_rule_v2 appropriately.

It looks like an aws_security_group_rule resource also exists, probably to get around the same kinds of limitations. I have no idea how this resource and aws_security_group work together, though - I'd imagine a user must choose one method or another.

It's a best practice to create a decoupled/independent resource for any API call that can be decoupled.

kayrus · 2018-12-20T06:33:18Z

Thanks for the feedback.

theopenlab-ci · 2018-12-30T10:13:41Z

Build failed.

terraform-provider-openstack-unittest : SUCCESS in 3m 02s
terraform-provider-openstack-acceptance-test : FAILURE in 2h 14m 40s

theopenlab-ci · 2018-12-30T21:12:16Z

Build failed.

terraform-provider-openstack-unittest : SUCCESS in 2m 45s
terraform-provider-openstack-acceptance-test : FAILURE in 2h 03m 32s

theopenlab-ci · 2018-12-31T00:07:22Z

Build failed.

terraform-provider-openstack-unittest : SUCCESS in 2m 49s
terraform-provider-openstack-acceptance-test : FAILURE in 2h 02m 29s

theopenlab-ci · 2018-12-31T09:47:52Z

Build failed.

terraform-provider-openstack-unittest : SUCCESS in 2m 43s
terraform-provider-openstack-acceptance-test : FAILURE in 1h 57m 05s

theopenlab-ci · 2019-01-02T09:28:42Z

Build failed.

terraform-provider-openstack-unittest : SUCCESS in 2m 52s
terraform-provider-openstack-acceptance-test : FAILURE in 10m 54s

theopenlab-ci · 2019-01-02T09:49:53Z

Build failed.

terraform-provider-openstack-unittest : SUCCESS in 2m 35s
terraform-provider-openstack-acceptance-test : FAILURE in 10m 07s

theopenlab-ci · 2019-01-02T11:05:09Z

Build failed.

terraform-provider-openstack-unittest : SUCCESS in 2m 43s
terraform-provider-openstack-acceptance-test : FAILURE in 13m 52s

theopenlab-ci · 2019-01-02T12:52:52Z

Build failed.

terraform-provider-openstack-unittest : SUCCESS in 2m 49s
terraform-provider-openstack-acceptance-test : FAILURE in 10m 25s

theopenlab-ci · 2019-01-02T18:17:19Z

Build succeeded.

terraform-provider-openstack-unittest : SUCCESS in 2m 47s
terraform-provider-openstack-acceptance-test : SUCCESS in 2h 09m 05s

kayrus · 2019-01-02T18:18:14Z

@jtopjian ready for review

jtopjian

@kayrus Thank you for this one, too! Let me know if you have any questions.

openstack/resource_openstack_sharedfilesystem_share_access_v2.go

jtopjian · 2019-01-04T02:52:21Z

openstack/resource_openstack_sharedfilesystem_share_access_v2.go

+
+	access, err := shares.ListAccessRights(sfsClient, shareId).Extract()
+	if err != nil {
+		return CheckDeleted(d, err, "share")


This is only checking for a 404 return code. Will this ever return a 404, even if no acls exist?

No, it wont. But if there is no share, it will return 404 and ACLs should be removed since they are subobjects of the share object.

openstack/resource_openstack_sharedfilesystem_share_access_v2.go

website/docs/r/sharedfilesystem_share_access_v2.html.markdown

theopenlab-ci · 2019-01-04T08:05:19Z

Build failed.

terraform-provider-openstack-unittest : SUCCESS in 2m 39s
terraform-provider-openstack-acceptance-test : FAILURE in 2h 35m 25s

theopenlab-ci · 2019-01-04T10:39:53Z

Build succeeded.

terraform-provider-openstack-unittest : SUCCESS in 2m 32s
terraform-provider-openstack-acceptance-test : SUCCESS in 2h 25m 12s

theopenlab-ci · 2019-01-04T15:53:33Z

Build succeeded.

terraform-provider-openstack-unittest : SUCCESS in 2m 50s
terraform-provider-openstack-acceptance-test : SUCCESS in 2h 35m 36s

jtopjian

LGTM. I'm going to squash and merge this PR to save you a rebase if I would merge #525 first.

ghost added size/XXL dependencies documentation labels Dec 14, 2018

kayrus force-pushed the manila-share-acl branch 2 times, most recently from 6ddc5fc to 2b5999a Compare December 17, 2018 12:09

kayrus force-pushed the manila-share-acl branch from 2b5999a to c03af0f Compare December 17, 2018 16:39

kayrus force-pushed the manila-share-acl branch from c03af0f to c9cc7f9 Compare December 30, 2018 07:58

kayrus force-pushed the manila-share-acl branch 2 times, most recently from 5ba4abe to e0e06d7 Compare December 30, 2018 19:06

kayrus force-pushed the manila-share-acl branch from e0e06d7 to 55bd79e Compare December 30, 2018 22:03

Manila: add share resource

d504aef

kayrus force-pushed the manila-share-acl branch from 55bd79e to 446918e Compare December 31, 2018 07:49

Manila: comment out the shrink test

9447bed

kayrus force-pushed the manila-share-acl branch from 446918e to ca0e94d Compare January 2, 2019 09:13

jtopjian requested changes Jan 4, 2019

View reviewed changes

Manila: minor code review changes

573b6c2

kayrus force-pushed the manila-share-acl branch 2 times, most recently from 372a7b3 to b5faa83 Compare January 4, 2019 05:28

kayrus force-pushed the manila-share-acl branch from b5faa83 to 20f3e62 Compare January 4, 2019 08:13

kayrus added 4 commits January 4, 2019 14:08

Manila: add detailed error handling

492a82c

Manila: add share_access resource (ACL)

128735a

Manila: minor code review and acl import support

b3dad63

Manila: add share access detailed error handling

7c8ad6b

kayrus force-pushed the manila-share-acl branch from 20f3e62 to 7c8ad6b Compare January 4, 2019 13:16

jtopjian approved these changes Jan 5, 2019

View reviewed changes

jtopjian merged commit 459c6b6 into terraform-provider-openstack:master Jan 5, 2019

jtopjian mentioned this pull request Jan 5, 2019

Manila: add share resource #525

Closed

kayrus deleted the manila-share-acl branch January 5, 2019 07:47

kayrus mentioned this pull request Jul 30, 2019

Key Manager V1: Introduce ACL resources for secrets and containers #812

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Manila: add share acl resource #526

Manila: add share acl resource #526

kayrus commented Dec 14, 2018

theopenlab-ci bot commented Dec 14, 2018

mrhillsman commented Dec 16, 2018

theopenlab-ci bot commented Dec 16, 2018

theopenlab-ci bot commented Dec 17, 2018

theopenlab-ci bot commented Dec 17, 2018

kayrus commented Dec 20, 2018

jtopjian commented Dec 20, 2018

kayrus commented Dec 20, 2018

theopenlab-ci bot commented Dec 30, 2018

theopenlab-ci bot commented Dec 30, 2018

theopenlab-ci bot commented Dec 31, 2018

theopenlab-ci bot commented Dec 31, 2018

theopenlab-ci bot commented Jan 2, 2019

theopenlab-ci bot commented Jan 2, 2019

theopenlab-ci bot commented Jan 2, 2019

theopenlab-ci bot commented Jan 2, 2019

theopenlab-ci bot commented Jan 2, 2019

kayrus commented Jan 2, 2019

jtopjian left a comment

jtopjian Jan 4, 2019

kayrus Jan 4, 2019

theopenlab-ci bot commented Jan 4, 2019

theopenlab-ci bot commented Jan 4, 2019

theopenlab-ci bot commented Jan 4, 2019

jtopjian left a comment

Manila: add share acl resource #526

Manila: add share acl resource #526

Conversation

kayrus commented Dec 14, 2018

theopenlab-ci bot commented Dec 14, 2018

mrhillsman commented Dec 16, 2018

theopenlab-ci bot commented Dec 16, 2018

theopenlab-ci bot commented Dec 17, 2018

theopenlab-ci bot commented Dec 17, 2018

kayrus commented Dec 20, 2018

jtopjian commented Dec 20, 2018

kayrus commented Dec 20, 2018

theopenlab-ci bot commented Dec 30, 2018

theopenlab-ci bot commented Dec 30, 2018

theopenlab-ci bot commented Dec 31, 2018

theopenlab-ci bot commented Dec 31, 2018

theopenlab-ci bot commented Jan 2, 2019

theopenlab-ci bot commented Jan 2, 2019

theopenlab-ci bot commented Jan 2, 2019

theopenlab-ci bot commented Jan 2, 2019

theopenlab-ci bot commented Jan 2, 2019

kayrus commented Jan 2, 2019

jtopjian left a comment

Choose a reason for hiding this comment

jtopjian Jan 4, 2019

Choose a reason for hiding this comment

kayrus Jan 4, 2019

Choose a reason for hiding this comment

theopenlab-ci bot commented Jan 4, 2019

theopenlab-ci bot commented Jan 4, 2019

theopenlab-ci bot commented Jan 4, 2019

jtopjian left a comment

Choose a reason for hiding this comment