Manila: add share resource

[kayrus]

Part of #502

[kayrus]

I'm afraid that functional tests won't work on OpenLab. They passed locally on rocky.

[theopenlab-ci]

Build failed.

• terraform-provider-openstack-unittest : SUCCESS in 2m 38s
• terraform-provider-openstack-acceptance-test : FAILURE in 2h 19m 35s

[kayrus]

As I expected (from the gophercloud PR, where I added explicitly skip of manila tests), shares are not created:

openstack_sharedfilesystem_share_v2.share_1: Error waiting for share a24fb1e6-1e88-4777-a301-0ed864b12b6b to become available: unexpected state 'error', wanted target 'available'. last error: %!s(<nil>)

@jtopjian did you get an update from OpenLab?

[kayrus]

Relates to gophercloud/gophercloud#1345

[jtopjian]

I've opened an issue here: theopenlab/openlab#142

This might delay this PR from being merged, but I'd like to leave it open for a few days for the OpenLab team to look into it. We can proceed with reviewing and making changes, but I want to keep Manila enabled so a recheck can reproduce the problem.

[theopenlab-ci]

Build failed.

• terraform-provider-openstack-unittest : SUCCESS in 2m 16s
• terraform-provider-openstack-acceptance-test : FAILURE in 1h 53m 12s

[theopenlab-ci]

Build failed.

• terraform-provider-openstack-unittest : SUCCESS in 2m 23s
• terraform-provider-openstack-acceptance-test : FAILURE in 2h 00m 53s

[huangtianhua]

recheck

[theopenlab-ci]

Build failed.

• terraform-provider-openstack-unittest : SUCCESS in 2m 57s
• terraform-provider-openstack-acceptance-test : FAILURE in 2h 03m 35s

[huangtianhua]

recheck

[theopenlab-ci]

Build failed.

• terraform-provider-openstack-unittest : SUCCESS in 3m 01s
• terraform-provider-openstack-acceptance-test : FAILURE in 2h 43m 11s

[huangtianhua]

please review theopenlab/openlab-zuul-jobs#398, we decide to set up devstack with manila enabling the LVM driver which operates in driver_handles_share_services=False mode, and please to modify your acctest to create share only with protocol, size and name, like "manila create NFS 1 --name test_share", no need to create network resources anymore.

[theopenlab-ci]

Build failed.

• terraform-provider-openstack-unittest : SUCCESS in 2m 37s
• terraform-provider-openstack-acceptance-test : FAILURE in 2h 13m 39s

[theopenlab-ci]

Build failed.

• terraform-provider-openstack-unittest : SUCCESS in 2m 37s
• terraform-provider-openstack-acceptance-test : FAILURE in 1h 59m 16s

[theopenlab-ci]

Build failed.

• terraform-provider-openstack-unittest : SUCCESS in 2m 41s
• terraform-provider-openstack-acceptance-test : FAILURE in 2h 01m 23s

[theopenlab-ci]

Build failed.

• terraform-provider-openstack-unittest : SUCCESS in 2m 45s
• terraform-provider-openstack-acceptance-test : FAILURE in 1h 58m 39s

[kayrus]

@h00130372, share creation and extending work, but shrinking fails.

[huangtianhua]

@kayrus, I think it's due to not all drivers support shrink feature, the mappings see:
https://github.com/openstack/manila/blob/master/doc/source/admin/share_back_ends_feature_support_mapping.rst
and now we enable lvm driver when setting up manila, lvm driver does not support shrink.

[theopenlab-ci]

Build failed.

• terraform-provider-openstack-unittest : SUCCESS in 2m 45s
• terraform-provider-openstack-acceptance-test : FAILURE in 10m 08s

[theopenlab-ci]

Build failed.

• terraform-provider-openstack-unittest : SUCCESS in 2m 45s
• terraform-provider-openstack-acceptance-test : FAILURE in 13m 52s

[theopenlab-ci]

Build failed.

• terraform-provider-openstack-unittest : SUCCESS in 2m 44s
• terraform-provider-openstack-acceptance-test : FAILURE in 10m 15s

[theopenlab-ci]

Build failed.

• terraform-provider-openstack-unittest : SUCCESS in 2m 47s
• terraform-provider-openstack-acceptance-test : FAILURE in 9m 56s

[theopenlab-ci]

Build succeeded.

• terraform-provider-openstack-unittest : SUCCESS in 2m 35s
• terraform-provider-openstack-acceptance-test : SUCCESS in 2h 08m 16s

[kayrus]

finally
@jtopjian ready for review

[jtopjian]

@kayrus Thank you for working on this. I apologize for the slow reviews - I'm back to work after a few weeks of vacation.

I've left a few comments. Please let me know if you have any questions or if I made a mistake.

[theopenlab-ci]

Build succeeded.

• terraform-provider-openstack-unittest : SUCCESS in 2m 51s
• terraform-provider-openstack-acceptance-test : SUCCESS in 2h 24m 09s

[kayrus]

Added detailed error messages. Now if the share source snapshot doesn't exists, terraform will print 404 detailed error message:

Error: Error applying plan:

1 error(s) occurred:

* openstack_sharedfilesystem_share_v2.share_2: 1 error(s) occurred:

* openstack_sharedfilesystem_share_v2.share_2: Error creating share: itemNotFound (404): ShareSnapshotNotFound: Snapshot 70bfbebc-d3ff-4528-8bbb-58422daa280b could not be found.

[theopenlab-ci]

Build succeeded.

• terraform-provider-openstack-unittest : SUCCESS in 2m 36s
• terraform-provider-openstack-acceptance-test : SUCCESS in 2h 01m 18s

[jtopjian]

Implemented as part of #526