Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block Storage v2: Fix volume detachment 404s #641

Merged
merged 2 commits into from
Feb 6, 2019
Merged

Block Storage v2: Fix volume detachment 404s #641

merged 2 commits into from
Feb 6, 2019

Conversation

jtopjian
Copy link
Contributor

For #639

Amending #640, we shouldn't use CheckDeleted for the volume detach
portion since CheckDeleted will remove the resource from state. Instead,
we should just consider a 404 an acceptable error and continue.

Too many Deletes and CheckDelete on my mind.

@jtopjian
Block Storage v2: Fix volume detachment 404s
612b756 
Amending terraform-provider-openstack#640, we shouldn't use CheckDeleted for the volume detach
portion since CheckDeleted will remove the resource from state. Instead,
we should just consider a 404 an acceptable error and continue.
@ghost ghost added the size/XS label Jan 24, 2019
@jtopjian jtopjian mentioned this pull request Jan 24, 2019
Closed
@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 24, 2019

Build failed.

@jtopjian
Copy link
Contributor Author

OpenLab unit test error is ignorable - it looks to be a transient "connection reset by peer". Travis passed, so unit tests are fine.

@jtopjian
Copy link
Contributor Author

recheck

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 27, 2019

Build succeeded.

@kayrus
Copy link
Collaborator

kayrus commented Jan 29, 2019 •
edited
Loading

@jtopjian could you please also cover this use case?

* openstack_blockstorage_volume_v3.volumes.4: Error detaching openstack_blockstorage_volume_v3 c9f17e72-380b-42e3-bcba-20e89b2b5af2 from 04f9a74c-f1e5-4bd9-9b93-1bcbd198352c: Expected HTTP response code [202 204] when accessing [DELETE http://compute:8080/v2.1/servers/04f9a74c-f1e5-4bd9-9b93-1bcbd198352c/os-volume_attachments/c9f17e72-380b-42e3-bcba-20e89b2b5af2], but got 409 instead {"conflictingRequest": {"message": "Cannot 'detach_volume' instance 04f9a74c-f1e5-4bd9-9b93-1bcbd198352c while it is in task_state deleting", "code": 409}}

@ghost ghost added size/S and removed size/XS labels Jan 30, 2019
@jtopjian
Copy link
Contributor Author

@kayrus That's a really good find!

I've pushed a new commit which I think will resolve it? Do you have a way of accurately reproducing this situation?

@kayrus
Copy link
Collaborator

kayrus commented Jan 30, 2019 •
edited
Loading

@jtopjian I'm performing so many use cases last days, so I already forgot what was the actual cause.

@jtopjian
Copy link
Contributor Author

No problem 🙂

The error message was clear enough, so I think it's now accounted for.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 30, 2019

Build succeeded.

ozerovandrei
ozerovandrei approved these changes Feb 6, 2019
View reviewed changes
Copy link
Member

@ozerovandrei ozerovandrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@ozerovandrei
Copy link
Member

@jtopjian I'll go and merge it since we have a new release in plan.

@ozerovandrei ozerovandrei merged commit 9198bbf into terraform-provider-openstack:master Feb 6, 2019
@jtopjian
Copy link
Contributor Author

jtopjian commented Feb 6, 2019

@ozerovandrei sounds good - thank you! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozerovandrei ozerovandrei ozerovandrei approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jtopjian @kayrus @ozerovandrei