r/lb_loadbalancer_v2: Remove 'provider' field #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@radeksimko I totally forgot about this -- thank you! |
gator1
pushed a commit
to gator1/terraform-provider-opentelekomcloud
that referenced
this pull request
Nov 27, 2017
…viders/remove-provider-field r/lb_loadbalancer_v2: Remove 'provider' field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecation was added in hashicorp/terraform#12239 (in February 2017).
That said the user wouldn't ever see the deprecation message because the whole field (along with some other reserved fields) is removed before CRUD even gets chance to process it.
https://github.com/hashicorp/terraform/blob/5bcc1bae5925f44208a83279b6d4d250da01597b/config/loader_hcl.go#L673-L676
This is first step towards bumping
hashicorp/terraformtov0.10.0which has validation for these kinds of things (see hashicorp/terraform#15562).