provider/openstack: Rename provider to loadbalancer_provider

[jtopjian]

This commit renames provider to loadbalancer_provider in the
openstack_lb_loadbalancer_v2 resource.

It also changes security_group_ids to Computed so default
security groups are added to the state correctly.

Fixes #12237

[stack72]

I don't believe we can just make this change - it's not backwards compatible

We are going to have to deprecate provider and then introduce the new loadbalancer_provider field

we will have to cater for both until 0.10

[jtopjian]

@stack72 I can definitely do a deprecation thing here.

Just curious, though: would provider have worked during any previous release? Was it only recent that the error reported in #12237 would happen? If so, that would definitely help my sanity :)

[jtopjian]

@stack72 I couldn't decide on leaving this part as-is or adding the following:

if v, ok := d.GetOk("provider"); ok && lbProvider == "" {
        lbProvider = v.(string)
}

The above would set lbProvider if provider was set and the new preferred loadbalancer_provider wasn't set. However, since having an argument of provider will error out anyway, is it worth adding the above block of code in?

[rcreasey]

FYI, I've validated this actually correctly sets the openstack_lb_loadbalancer_v2 provider attribute against an actual OpenStack Neutron API.

edit: disregard previous comments; secgroups change looks good.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.