-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Networking V2: add QoS Policy resource #774
Merged
ozerovandrei
merged 2 commits into
terraform-provider-openstack:master
from
ozerovandrei:net-v2-qos-policies-resource
Jun 19, 2019
Merged
Networking V2: add QoS Policy resource #774
ozerovandrei
merged 2 commits into
terraform-provider-openstack:master
from
ozerovandrei:net-v2-qos-policies-resource
Jun 19, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build failed.
|
Implement "openstack_networking_qos_policy_v2" resource with acceptance tests and website documentation.
Build succeeded.
|
jtopjian
requested changes
Jun 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ozerovandrei just one minor change. I haven't tested this myself, though.
Really nice work!
Move "QoSPolicyCreateOpts" type into openstack/networking_qos_policy_v2.go.
Build failed.
|
recheck |
Build failed.
|
recheck |
1 similar comment
recheck |
Build succeeded.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement "openstack_networking_qos_policy_v2" resource with acceptance
tests and website documentation.
For #760