-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to disable status check in resource_openstack_dns_zone_v2 #1114
Allow to disable status check in resource_openstack_dns_zone_v2 #1114
Conversation
recheck designate |
Why is openlab pending? Should I do something? |
recheck designate |
Build succeeded.
|
Build failed.
|
recheck designate |
I think I've fixed the tests, please, run them again |
No, it seems that I haven't fixed them, trying again. |
This will allow terraform to tolerate some backend issues in Designate. If zone is created in Designate, and even all the backends are down, Designate will try to recover. If only one of the backends is down, zone will be in ERROR state, but will be served by other backends. In this case, waiting for ACTIVE state also doesn't make sense.
I hope this is how tests should be fixed. I've looked into other resources (like compute_instance_v2) to see how virtual attributes are handled on import. |
recheck designate |
@ozerovandrei Please, run designate tests again. It seems that my commands are able to set them to pending state only. |
@ya-isakov there seems to be some problems with Zuul since a lots of jobs are in the "unknown" state: http://status.openlabtesting.org/status I also tried recheck here: #1117 and it didn't work. I've just opened the issue: theopenlab/openlab#642 |
recheck |
recheck designate |
Build succeeded.
|
Build succeeded.
|
@ozerovandrei Please, review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you! |
This will allow terraform to tolerate some backend issues in Designate. If zone is created in Designate, and even all the backends are down, Designate will try to recover.
If only one of the backends is down, zone will be in ERROR state, but will be served by other backends. In this case, waiting for ACTIVE state also doesn't make sense.