Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to disable status check in resource_openstack_dns_zone_v2 #1114

Merged
merged 1 commit into from
Dec 18, 2020

Conversation

ya-isakov
Copy link
Contributor

This will allow terraform to tolerate some backend issues in Designate. If zone is created in Designate, and even all the backends are down, Designate will try to recover.

If only one of the backends is down, zone will be in ERROR state, but will be served by other backends. In this case, waiting for ACTIVE state also doesn't make sense.

@ya-isakov
Copy link
Contributor Author

recheck designate

@ya-isakov
Copy link
Contributor Author

Why is openlab pending? Should I do something?

@ozerovandrei
Copy link
Member

recheck designate

@theopenlab-ci
Copy link

theopenlab-ci bot commented Dec 15, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Dec 15, 2020

Build failed.

@ya-isakov
Copy link
Contributor Author

recheck designate

@ya-isakov
Copy link
Contributor Author

I think I've fixed the tests, please, run them again

@ya-isakov
Copy link
Contributor Author

No, it seems that I haven't fixed them, trying again.

This will allow terraform to tolerate some backend issues in Designate.
If zone is created in Designate, and even all the backends are down,
Designate will try to recover.
If only one of the backends is down, zone will be in ERROR state, but
will be served by other backends. In this case, waiting for ACTIVE state
also doesn't make sense.
@ya-isakov
Copy link
Contributor Author

I hope this is how tests should be fixed. I've looked into other resources (like compute_instance_v2) to see how virtual attributes are handled on import.

@ya-isakov
Copy link
Contributor Author

recheck designate

@ya-isakov
Copy link
Contributor Author

ya-isakov commented Dec 17, 2020

@ozerovandrei Please, run designate tests again. It seems that my commands are able to set them to pending state only.

@ozerovandrei
Copy link
Member

ozerovandrei commented Dec 17, 2020

@ya-isakov there seems to be some problems with Zuul since a lots of jobs are in the "unknown" state: http://status.openlabtesting.org/status

I also tried recheck here: #1117 and it didn't work.

I've just opened the issue: theopenlab/openlab#642

@ya-isakov
Copy link
Contributor Author

recheck

@ya-isakov
Copy link
Contributor Author

recheck designate

@theopenlab-ci
Copy link

theopenlab-ci bot commented Dec 18, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Dec 18, 2020

Build succeeded.

@ya-isakov
Copy link
Contributor Author

@ozerovandrei Please, review.

Copy link
Member

@ozerovandrei ozerovandrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ozerovandrei ozerovandrei merged commit a498d03 into terraform-provider-openstack:master Dec 18, 2020
@ya-isakov
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants