Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Networking: introduce openstack_networking_subnet_ids_v2 data source #1153

Merged
merged 1 commit into from
Jan 31, 2021

Conversation

kayrus
Copy link
Collaborator

@kayrus kayrus commented Jan 29, 2021

This is an efficient way (comparing to #1152) to filter out network subnet IDs by a certain criteria. See a #1150 for a reference.

P.S. Fixed a couple of tiny bugs and docs typos while worked on the PR. I also deprecated dhcp_disabled in data.openstack_networking_subnet_v2, because it was introduced before Terraform SDK started to support the GetOkExists method.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 29, 2021

Build succeeded.

Copy link
Member

@ozerovandrei ozerovandrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ozerovandrei ozerovandrei merged commit 1200022 into terraform-provider-openstack:main Jan 31, 2021
@kayrus kayrus deleted the subnet-ids branch January 31, 2021 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants