Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blockstorage_quotaset_v3: Add volume type quota support #1185

Merged
merged 2 commits into from
Feb 27, 2021
Merged

blockstorage_quotaset_v3: Add volume type quota support #1185

merged 2 commits into from
Feb 27, 2021

Conversation

nikParasyr
Copy link
Member

Related to: #979

Gophercloud added support for volume_type quota with: gophercloud/gophercloud#2109

This PR requires both #1180 and #1183

@nikParasyr
Copy link
Member Author

I have tested this on a test cluster and it works. I cannot update the tests to include this functionality as:

  • we dont have a resource to create volume_types (I might look to add it later on)
  • the existing volume types change for each cloud, so i dont want to hardcode anything that only works for openlab

@nikParasyr nikParasyr marked this pull request as draft February 24, 2021 16:54
@theopenlab-ci
Copy link

theopenlab-ci bot commented Feb 24, 2021

Build succeeded.

@nikParasyr nikParasyr marked this pull request as ready for review February 26, 2021 16:07
@theopenlab-ci
Copy link

theopenlab-ci bot commented Feb 26, 2021

Build succeeded.

ozerovandrei
ozerovandrei approved these changes Feb 27, 2021
View reviewed changes
Copy link
Member

@ozerovandrei ozerovandrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ozerovandrei ozerovandrei merged commit a39e1df into terraform-provider-openstack:main Feb 27, 2021
@nikParasyr nikParasyr deleted the volume_type_quota_v3 branch March 16, 2021 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozerovandrei ozerovandrei ozerovandrei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nikParasyr @ozerovandrei