Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate various nova resources #1639

Merged

Conversation

nikParasyr
Copy link
Member

Mark compute_floatingip_associate_v2, compute_floatingip_v2, compute_secgroup_v2 as deprecated. Add a deprecation message to point to the related neutron resources to be used instead. Move their doc pages into the Deprecated subcategory.

Mark compute_floatingip_associate_v2, compute_floatingip_v2,
compute_secgroup_v2 as deprecated. Add a deprecation message
to point to the related neutron resources to be used instead.
Move their doc pages into the `Deprecated` subcategory.
@nikParasyr nikParasyr requested a review from kayrus January 5, 2024 13:31
Copy link
Collaborator

@kayrus kayrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kayrus
Copy link
Collaborator

kayrus commented Jan 5, 2024

2024-01-05T13:53:18.2413059Z 2024-01-05T13:53:18.239Z [ERROR] sdk.proto: Response contains error diagnostic: diagnostic_summary="Error detaching openstack_compute_interface_attach_v2 f81329b4-0325-4629-ae34-21f7f311ce3a/1ef8227f-9f51-49f2-bc34-410e1153f675: couldn't find resource (21 retries)" tf_rpc=ApplyResourceChange tf_req_id=21d3df3d-73a3-c05b-9256-541a8841cb4d tf_provider_addr=registry.terraform.io/hashicorp/openstack tf_resour
ce_type=openstack_compute_interface_attach_v2 tf_proto_version=5.4 diagnostic_detail="" diagnostic_severity=ERROR
2024-01-05T13:53:18.2451898Z 2024-01-05T13:53:18.244Z [WARN]  sdk.helper_resource: Error running Terraform CLI command: test_terraform_path=/usr/local/bin/terraform
2024-01-05T13:53:18.2453227Z   error=
2024-01-05T13:53:18.2453624Z   | exit status 1
2024-01-05T13:53:18.2454003Z   | 
2024-01-05T13:53:18.2455772Z   | Error: Error detaching openstack_compute_interface_attach_v2 f81329b4-0325-4629-ae34-21f7f311ce3a/1ef8227f-9f51-49f2-bc34-410e1153f675: couldn't find resource (21 retries)
2024-01-05T13:53:18.2457276Z   | 
2024-01-05T13:53:18.2458452Z    test_step_number=2 test_working_directory=/tmp/plugintest3608714075 test_name=TestAccComputeV2InterfaceAttachImport_basic
2024-01-05T13:53:18.2461757Z 2024-01-05T13:53:18.244Z [DEBUG] sdk.helper_resource: Stopping providers: test_working_directory=/tmp/plugintest3608714075 test_name=TestAccComputeV2InterfaceAttachImport_basic test_terraform_path=/usr/local/bin/terraform test_step_number=2
2024-01-05T13:53:18.2464506Z 2024-01-05T13:53:18.245Z [ERROR] sdk.helper_resource: Error running post-test destroy, there may be dangling resources: test_terraform_path=/usr/local/bin/terraform
2024-01-05T13:53:18.2466022Z   error=
2024-01-05T13:53:18.2466437Z   | exit status 1
2024-01-05T13:53:18.2466824Z   | 
2024-01-05T13:53:18.2468917Z   | Error: Error detaching openstack_compute_interface_attach_v2 f81329b4-0325-4629-ae34-21f7f311ce3a/1ef8227f-9f51-49f2-bc34-410e1153f675: couldn't find resource (21 retries)
2024-01-05T13:53:18.2470490Z   | 
2024-01-05T13:53:18.2474058Z    test_step_number=2 test_working_directory=/tmp/plugintest3608714075 test_name=TestAccComputeV2InterfaceAttachImport_basic
2024-01-05T13:53:18.2475482Z     testing_new.go:85: Error running post-test destroy, there may be dangling resources: exit status 1
2024-01-05T13:53:18.2476438Z         
2024-01-05T13:53:18.2479609Z         Error: Error detaching openstack_compute_interface_attach_v2 f81329b4-0325-4629-ae34-21f7f311ce3a/1ef8227f-9f51-49f2-bc34-410e1153f675: couldn't find resource (21 retries)
2024-01-05T13:53:18.2481065Z         
2024-01-05T13:53:18.2481778Z --- FAIL: TestAccComputeV2InterfaceAttachImport_basic (219.46s)

@nikParasyr nikParasyr merged commit aac2a24 into terraform-provider-openstack:main Jan 5, 2024
7 checks passed
@nikParasyr nikParasyr deleted the deprecate_nova branch January 5, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants