Vpnaas: VPN service resource #300
Conversation
|
Build failed.
|
|
@jtopjian Unless I'm misinterpreting the openlab logs I don't think that this is a problem with my code (?) This PR has the same problem as gophercloud/gophercloud#784 with the update function of the service resource. I put in a test that succeeds on error instead of a 'real' test of the functionality although I'm not sure that this really makes sense. Also apart from the same issue as #270 this is ready for review. |
That's correct -- you can ignore the results of OpenLab acceptance tests with these VPNaaS PRs. |
There was a problem hiding this comment.
@simonre Two small error checks. In addition, a sidebar entry in openstack.erb will also need to be created.
I put in a test that succeeds on error instead of a 'real' test of the functionality although I'm not sure that this really makes sense.
I apologize - I didn't see this part earlier. On Monday, I'll ask some of the Terraform devs about what to do in this scenario. Maybe there's a way to easily mock or stub the test or just do some basic exercises of the attributes.
| Delay: 0, | ||
| MinTimeout: 2 * time.Second, | ||
| } | ||
| _, err = stateConf.WaitForState() |
There was a problem hiding this comment.
if err != nil {
return err
}| Delay: 0, | ||
| MinTimeout: 2 * time.Second, | ||
| } | ||
| _, err = stateConf.WaitForState() |
There was a problem hiding this comment.
if err != nil {
return err
}
|
@jtopjian Apart from the test issue this is ready for review again. |
|
Build succeeded.
|
|
@simonre I have no idea why I misread your notes twice. Since the problem is only with updating, then I'm OK with omitting update tests. If we can test creation, then that's good enough and will exercise a good amount of code in this resource. |
|
Build failed.
|
|
@jtopjian I removed the update test and rebased the code. |
Part 2 of a series that addresses #2