Add tags support for Neutron Subnetpools #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Build succeeded.
|
added 3 commits
October 29, 2018 19:20
This allows us to set/get tags for networks via terraform templates, and requires the recently added changes to gophercloud that enable the relevant features of the Neutron APIs to be accessed. Note the test is added in a new resource_openstack_networking_tags_v2_test.go file, so that we can reduce duplication later in the series e.g subnet/port/trunk resources can share the same template which should be faster. Issue: terraform-provider-openstack#453
This allows us to set/get tags for subnets via terraform templates, and requires the recently added changes to gophercloud that enable the relevant features of the Neutron APIs to be accessed. Issue: terraform-provider-openstack#453
This allows us to set/get tags for subnetpools via terraform templates, and requires the recently added changes to gophercloud that enable the relevant features of the Neutron APIs to be accessed. Issue: terraform-provider-openstack#453
hardys
force-pushed
the
neutron_tags_subnetpool
branch
from
24308d2
to
584771a
Compare
|
Build succeeded.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for tags to subnetpools note this is branched from PR #459
Subsequent PRs will add support for the other neutron resources which support standard attribute tags as described in Issue #453
Issue #453