Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

increase cognito scope limit #10505

Merged
merged 1 commit into from
Jan 18, 2020
Merged

increase cognito scope limit #10505

merged 1 commit into from
Jan 18, 2020

Conversation

dtsung3d
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:

Increased cognito scope based on updated API docs
https://docs.aws.amazon.com/cognito-user-identity-pools/latest/APIReference/API_CreateUserPoolClient.html#CognitoUserPools-CreateUserPoolClient-request-AllowedOAuthScopes

https://docs.aws.amazon.com/cognito-user-identity-pools/latest/APIReference/API_CreateResourceServer.html#API_CreateResourceServer_RequestSyntax

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestValidate -timeout 120m
=== RUN   TestValidateAppautoscalingPolicyImportInput
--- PASS: TestValidateAppautoscalingPolicyImportInput (0.00s)
=== RUN   TestValidateCloudWatchLogStreamName
--- PASS: TestValidateCloudWatchLogStreamName (0.00s)
=== RUN   TestValidateAwsEcsTaskDefinitionContainerDefinitions
--- PASS: TestValidateAwsEcsTaskDefinitionContainerDefinitions (0.00s)
=== RUN   TestValidateIamGroupName
--- PASS: TestValidateIamGroupName (0.00s)
=== RUN   TestValidateIamUserName
--- PASS: TestValidateIamUserName (0.00s)
=== RUN   TestValidateRedshiftClusterDbName
--- PASS: TestValidateRedshiftClusterDbName (0.00s)
=== RUN   TestValidateTypeStringNullableBoolean
--- PASS: TestValidateTypeStringNullableBoolean (0.00s)
=== RUN   TestValidateTypeStringNullableFloat
--- PASS: TestValidateTypeStringNullableFloat (0.00s)
=== RUN   TestValidateCloudWatchDashboardName
--- PASS: TestValidateCloudWatchDashboardName (0.00s)
=== RUN   TestValidateCloudWatchEventRuleName
--- PASS: TestValidateCloudWatchEventRuleName (0.00s)
=== RUN   TestValidateLambdaFunctionName
--- PASS: TestValidateLambdaFunctionName (0.00s)
=== RUN   TestValidateLambdaQualifier
--- PASS: TestValidateLambdaQualifier (0.00s)
=== RUN   TestValidateLambdaPermissionAction
--- PASS: TestValidateLambdaPermissionAction (0.00s)
=== RUN   TestValidateLambdaPermissionEventSourceToken
--- PASS: TestValidateLambdaPermissionEventSourceToken (0.00s)
=== RUN   TestValidateAwsAccountId
--- PASS: TestValidateAwsAccountId (0.00s)
=== RUN   TestValidateArn
--- PASS: TestValidateArn (0.00s)
=== RUN   TestValidateEC2AutomateARN
--- PASS: TestValidateEC2AutomateARN (0.00s)
=== RUN   TestValidatePolicyStatementId
--- PASS: TestValidatePolicyStatementId (0.00s)
=== RUN   TestValidateCIDRNetworkAddress
--- PASS: TestValidateCIDRNetworkAddress (0.00s)
=== RUN   TestValidateLogMetricFilterName
--- PASS: TestValidateLogMetricFilterName (0.00s)
=== RUN   TestValidateLogMetricTransformationName
--- PASS: TestValidateLogMetricTransformationName (0.00s)
=== RUN   TestValidateLogGroupName
--- PASS: TestValidateLogGroupName (0.00s)
=== RUN   TestValidateLogGroupNamePrefix
--- PASS: TestValidateLogGroupNamePrefix (0.00s)
=== RUN   TestValidateS3BucketLifecycleTimestamp
--- PASS: TestValidateS3BucketLifecycleTimestamp (0.00s)
=== RUN   TestValidateSagemakerName
--- PASS: TestValidateSagemakerName (0.00s)
=== RUN   TestValidateDbEventSubscriptionName
--- PASS: TestValidateDbEventSubscriptionName (0.00s)
=== RUN   TestValidateIAMPolicyJsonString
--- PASS: TestValidateIAMPolicyJsonString (0.00s)
=== RUN   TestValidateCloudFormationTemplate
--- PASS: TestValidateCloudFormationTemplate (0.00s)
=== RUN   TestValidateSQSQueueName
--- PASS: TestValidateSQSQueueName (0.00s)
=== RUN   TestValidateSQSFifoQueueName
--- PASS: TestValidateSQSFifoQueueName (0.00s)
=== RUN   TestValidateOnceAWeekWindowFormat
--- PASS: TestValidateOnceAWeekWindowFormat (0.00s)
=== RUN   TestValidateOnceADayWindowFormat
--- PASS: TestValidateOnceADayWindowFormat (0.00s)
=== RUN   TestValidateEcsPlacementConstraint
--- PASS: TestValidateEcsPlacementConstraint (0.00s)
=== RUN   TestValidateEcsPlacementStrategy
--- PASS: TestValidateEcsPlacementStrategy (0.00s)
=== RUN   TestValidateStepFunctionStateMachineName
--- PASS: TestValidateStepFunctionStateMachineName (0.00s)
=== RUN   TestValidateEmrCustomAmiId
--- PASS: TestValidateEmrCustomAmiId (0.00s)
=== RUN   TestValidateDmsEndpointId
--- PASS: TestValidateDmsEndpointId (0.00s)
=== RUN   TestValidateDmsCertificateId
--- PASS: TestValidateDmsCertificateId (0.00s)
=== RUN   TestValidateDmsReplicationInstanceId
--- PASS: TestValidateDmsReplicationInstanceId (0.00s)
=== RUN   TestValidateDmsReplicationSubnetGroupId
--- PASS: TestValidateDmsReplicationSubnetGroupId (0.00s)
=== RUN   TestValidateDmsReplicationTaskId
--- PASS: TestValidateDmsReplicationTaskId (0.00s)
=== RUN   TestValidateAccountAlias
--- PASS: TestValidateAccountAlias (0.00s)
=== RUN   TestValidateIamRoleProfileName
--- PASS: TestValidateIamRoleProfileName (0.00s)
=== RUN   TestValidateIamRoleProfileNamePrefix
--- PASS: TestValidateIamRoleProfileNamePrefix (0.00s)
=== RUN   TestValidateApiGatewayUsagePlanQuotaSettings
--- PASS: TestValidateApiGatewayUsagePlanQuotaSettings (0.00s)
=== RUN   TestValidateElbName
--- PASS: TestValidateElbName (0.00s)
=== RUN   TestValidateElbNamePrefix
--- PASS: TestValidateElbNamePrefix (0.00s)
=== RUN   TestValidateNeptuneEventSubscriptionName
--- PASS: TestValidateNeptuneEventSubscriptionName (0.00s)
=== RUN   TestValidateNeptuneEventSubscriptionNamePrefix
--- PASS: TestValidateNeptuneEventSubscriptionNamePrefix (0.00s)
=== RUN   TestValidateDbSubnetGroupName
--- PASS: TestValidateDbSubnetGroupName (0.00s)
=== RUN   TestValidateNeptuneSubnetGroupName
--- PASS: TestValidateNeptuneSubnetGroupName (0.00s)
=== RUN   TestValidateDbSubnetGroupNamePrefix
--- PASS: TestValidateDbSubnetGroupNamePrefix (0.00s)
=== RUN   TestValidateNeptuneSubnetGroupNamePrefix
--- PASS: TestValidateNeptuneSubnetGroupNamePrefix (0.00s)
=== RUN   TestValidateDbOptionGroupName
--- PASS: TestValidateDbOptionGroupName (0.00s)
=== RUN   TestValidateDbOptionGroupNamePrefix
--- PASS: TestValidateDbOptionGroupNamePrefix (0.00s)
=== RUN   TestValidateDbParamGroupName
--- PASS: TestValidateDbParamGroupName (0.00s)
=== RUN   TestValidateOpenIdURL
--- PASS: TestValidateOpenIdURL (0.00s)
=== RUN   TestValidateAwsKmsName
--- PASS: TestValidateAwsKmsName (0.00s)
=== RUN   TestValidateAwsKmsGrantName
--- PASS: TestValidateAwsKmsGrantName (0.00s)
=== RUN   TestValidateCognitoIdentityPoolName
--- PASS: TestValidateCognitoIdentityPoolName (0.00s)
=== RUN   TestValidateCognitoProviderDeveloperName
--- PASS: TestValidateCognitoProviderDeveloperName (0.00s)
=== RUN   TestValidateCognitoSupportedLoginProviders
--- PASS: TestValidateCognitoSupportedLoginProviders (0.00s)
=== RUN   TestValidateCognitoIdentityProvidersClientId
--- PASS: TestValidateCognitoIdentityProvidersClientId (0.00s)
=== RUN   TestValidateCognitoIdentityProvidersProviderName
--- PASS: TestValidateCognitoIdentityProvidersProviderName (0.00s)
=== RUN   TestValidateCognitoUserPoolEmailVerificationMessage
--- PASS: TestValidateCognitoUserPoolEmailVerificationMessage (0.01s)
=== RUN   TestValidateCognitoUserPoolEmailVerificationSubject
--- PASS: TestValidateCognitoUserPoolEmailVerificationSubject (0.00s)
=== RUN   TestValidateCognitoUserPoolSmsAuthenticationMessage
--- PASS: TestValidateCognitoUserPoolSmsAuthenticationMessage (0.00s)
=== RUN   TestValidateCognitoUserPoolSmsVerificationMessage
--- PASS: TestValidateCognitoUserPoolSmsVerificationMessage (0.00s)
=== RUN   TestValidateWafMetricName
--- PASS: TestValidateWafMetricName (0.00s)
=== RUN   TestValidateIamRoleDescription
--- PASS: TestValidateIamRoleDescription (0.00s)
=== RUN   TestValidateAwsSSMName
--- PASS: TestValidateAwsSSMName (0.00s)
=== RUN   TestValidateBatchName
--- PASS: TestValidateBatchName (0.00s)
=== RUN   TestValidateCognitoRoleMappingsAmbiguousRoleResolutionAgainstType
--- PASS: TestValidateCognitoRoleMappingsAmbiguousRoleResolutionAgainstType (0.00s)
=== RUN   TestValidateCognitoRoleMappingsRulesConfiguration
--- PASS: TestValidateCognitoRoleMappingsRulesConfiguration (0.00s)
=== RUN   TestValidateSecurityGroupRuleDescription
--- PASS: TestValidateSecurityGroupRuleDescription (0.00s)
=== RUN   TestValidateCognitoRoles
--- PASS: TestValidateCognitoRoles (0.00s)
=== RUN   TestValidateKmsKey
--- PASS: TestValidateKmsKey (0.00s)
=== RUN   TestValidateCognitoUserGroupName
--- PASS: TestValidateCognitoUserGroupName (0.00s)
=== RUN   TestValidateCognitoUserPoolId
--- PASS: TestValidateCognitoUserPoolId (0.00s)
=== RUN   TestValidateAmazonSideAsn
--- PASS: TestValidateAmazonSideAsn (0.00s)
=== RUN   TestValidateLaunchTemplateName
--- PASS: TestValidateLaunchTemplateName (0.00s)
=== RUN   TestValidateLaunchTemplateId
--- PASS: TestValidateLaunchTemplateId (0.00s)
=== RUN   TestValidateNeptuneParamGroupName
--- PASS: TestValidateNeptuneParamGroupName (0.00s)
=== RUN   TestValidateNeptuneParamGroupNamePrefix
--- PASS: TestValidateNeptuneParamGroupNamePrefix (0.00s)
=== RUN   TestValidateCloudFrontPublicKeyName
--- PASS: TestValidateCloudFrontPublicKeyName (0.00s)
=== RUN   TestValidateCloudFrontPublicKeyNamePrefix
--- PASS: TestValidateCloudFrontPublicKeyNamePrefix (0.00s)
=== RUN   TestValidateDxConnectionBandWidth
--- PASS: TestValidateDxConnectionBandWidth (0.00s)
=== RUN   TestValidateLbTargetGroupName
--- PASS: TestValidateLbTargetGroupName (0.00s)
=== RUN   TestValidateLbTargetGroupNamePrefix
--- PASS: TestValidateLbTargetGroupNamePrefix (0.00s)
=== RUN   TestValidateSecretManagerSecretName
--- PASS: TestValidateSecretManagerSecretName (0.00s)
=== RUN   TestValidateSecretManagerSecretNamePrefix
--- PASS: TestValidateSecretManagerSecretNamePrefix (0.00s)
=== RUN   TestValidateRoute53ResolverName
--- PASS: TestValidateRoute53ResolverName (0.00s)
PASS

...

@dtsung3d dtsung3d requested a review from a team October 14, 2019 21:47
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/cognito labels Oct 14, 2019
@bflad bflad added the bug Addresses a defect in current functionality. label Jan 17, 2020
@bflad bflad added this to the v2.46.0 milestone Jan 18, 2020
bflad
bflad approved these changes Jan 18, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this fix @dtsung3d 🚀

Output from acceptance testing:

--- PASS: TestAccAWSCognitoUserPoolClient_allFields (9.76s)
--- PASS: TestAccAWSCognitoUserPoolClient_basic (9.95s)
--- PASS: TestAccAWSCognitoUserPoolClient_Name (15.21s)
--- PASS: TestAccAWSCognitoUserPoolClient_RefreshTokenValidity (15.27s)
--- PASS: TestAccAWSCognitoResourceServer_basic (15.43s)
--- PASS: TestAccAWSCognitoUserPoolClient_allFieldsUpdatingOneField (15.91s)
--- PASS: TestAccAWSCognitoResourceServer_scope (19.41s)

@bflad bflad merged commit 6371422 into hashicorp:master Jan 18, 2020
bflad added a commit that referenced this pull request Jan 18, 2020
@bflad
Update CHANGELOG for #10505
465cce6
@ghost
Copy link

ghost commented Jan 23, 2020

This has been released in version 2.46.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v2.46.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dtsung3d @bflad