Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tag Support to API Gateway Domain Name Resource #10567

Merged

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #8744

Release note for CHANGELOG:

- resource/resource_aws_api_gateway_domain_name: Add `tags` argument.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSAPIGatewayDomainName_'

=== RUN   TestAccAWSAPIGatewayDomainName_CertificateArn
--- SKIP: TestAccAWSAPIGatewayDomainName_CertificateArn (0.00s)
    resource_aws_api_gateway_domain_name_test.go:19: Environment variable AWS_API_GATEWAY_DOMAIN_NAME_CERTIFICATE_ARN is not set. This environment variable must be set to the ARN of an ISSUED ACM certificate in us-east-1 to enable this test.

Test ignored.
=== RUN   TestAccAWSAPIGatewayDomainName_CertificateName
--- SKIP: TestAccAWSAPIGatewayDomainName_CertificateName (0.00s)
    resource_aws_api_gateway_domain_name_test.go:57: Environment variable AWS_API_GATEWAY_DOMAIN_NAME_CERTIFICATE_BODY is not set. This environment variable must be set to any non-empty value with a publicly trusted certificate body to enable the test.

Test ignored.
=== RUN   TestAccAWSAPIGatewayDomainName_RegionalCertificateArn
=== PAUSE TestAccAWSAPIGatewayDomainName_RegionalCertificateArn
=== CONT  TestAccAWSAPIGatewayDomainName_RegionalCertificateArn
--- PASS: TestAccAWSAPIGatewayDomainName_RegionalCertificateArn (110.27s)
=== RUN   TestAccAWSAPIGatewayDomainName_RegionalCertificateName
--- SKIP: TestAccAWSAPIGatewayDomainName_RegionalCertificateName (0.00s)
    resource_aws_api_gateway_domain_name_test.go:151: Environment variable AWS_API_GATEWAY_DOMAIN_NAME_REGIONAL_CERTIFICATE_NAME_ENABLED is not set. This environment variable must be set to any non-empty value in a region where uploading REGIONAL certificates is allowed to enable the test.

Test ignored.
=== RUN   TestAccAWSAPIGatewayDomainName_SecurityPolicy
=== PAUSE TestAccAWSAPIGatewayDomainName_SecurityPolicy
=== CONT  TestAccAWSAPIGatewayDomainName_SecurityPolicy
--- PASS: TestAccAWSAPIGatewayDomainName_SecurityPolicy (162.39s)
=== RUN   TestAccAWSAPIGatewayDomainName_Tags
=== PAUSE TestAccAWSAPIGatewayDomainName_Tags
=== CONT  TestAccAWSAPIGatewayDomainName_Tags
--- PASS: TestAccAWSAPIGatewayDomainName_Tags (159.41s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	169.083s

...

@DrFaust92 DrFaust92 requested a review from a team October 20, 2019 16:09
@ghost ghost added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/apigateway Issues and PRs that pertain to the apigateway service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 20, 2019
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 4, 2019
@bflad bflad added this to the v2.35.0 milestone Nov 4, 2019
Copy link
Member

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @DrFaust92 🚀

--- PASS: TestAccAWSAPIGatewayDomainName_SecurityPolicy (19.30s)
--- PASS: TestAccAWSAPIGatewayDomainName_Tags (106.29s)
--- PASS: TestAccAWSAPIGatewayDomainName_RegionalCertificateArn (113.13s)

@bflad bflad merged commit a91ad54 into hashicorp:master Nov 4, 2019
bflad added a commit that referenced this pull request Nov 4, 2019
@ghost
Copy link

ghost commented Nov 7, 2019

This has been released in version 2.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@DrFaust92 DrFaust92 deleted the api-gateway-domain-name-tag-support branch November 9, 2019 12:41
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/apigateway Issues and PRs that pertain to the apigateway service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants