pull changes #2
Merged
pull changes #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference: #10023 Output from acceptance testing: ``` --- PASS: TestAccAWSDataSourceIAMServerCertificate_matchNamePrefix (3.55s) --- PASS: TestAccAWSIAMServerCertificate_disappears (9.30s) --- PASS: TestAccAWSIAMServerCertificate_name_prefix (10.17s) --- PASS: TestAccAWSIAMServerCertificate_basic (11.28s) --- PASS: TestAccAWSDataSourceIAMServerCertificate_basic (12.65s) --- PASS: TestAccAWSDataSourceIAMServerCertificate_path (12.71s) --- PASS: TestAccAWSIAMServerCertificate_file (17.00s) ```
Found via `deadcode` linter:
```
aws/resource_aws_iam_server_certificate_test.go:274:6: `testAccIAMServerCertConfig_path` is unused (deadcode)
func testAccIAMServerCertConfig_path(rName, path, key, certificate string) string {
^
GNUmakefile:38: recipe for target 'lint' failed
make: *** [lint] Error 1
```
This happened because there was a data source configuration previously relying on that function. We typically discourage cross-file test configuration handling. This adds a resource test to cover the path argument functionality, separate from the data source testing.
Output from acceptance testing:
```
--- PASS: TestAccAWSIAMServerCertificate_Path (10.94s)
```
Some of these expensive resources were being left behind from AWS GovCloud (US) acceptance testing, making our monthly bill much higher than it should be. Output from sweeper in AWS Commercial: ```console $ go test ./aws -v -sweep=us-east-1,us-west-2 -sweep-run=aws_dms_replication_instance -timeout 10h 2019/10/01 21:36:57 [DEBUG] Running Sweepers for region (us-east-1): ... 2019/10/01 21:36:59 Sweeper Tests ran: - aws_dms_replication_instance 2019/10/01 21:36:59 [DEBUG] Running Sweepers for region (us-west-2): ... 2019/10/01 21:37:01 Sweeper Tests ran: - aws_dms_replication_instance ok github.com/terraform-providers/terraform-provider-aws/aws 4.834s ``` Output from sweeper in AWS GovCloud (US): ```console $ go test ./aws -v -sweep=us-gov-west-1 -sweep-run=aws_dms_replication_instance -timeout 10h 2019/10/01 21:35:24 [DEBUG] Running Sweepers for region (us-gov-west-1): ... 2019/10/01 21:35:26 [INFO] Deleting DMS Replication Instance: arn:aws-us-gov:dms:us-gov-west-1:--OMITTED--:rep:DVR3X3PURO6GMO2YO7VHU4XSLQ 2019/10/01 21:37:42 [INFO] Deleting DMS Replication Instance: arn:aws-us-gov:dms:us-gov-west-1:--OMITTED--:rep:GABWNTBQEDQYJTV3AOJIRLJVTM 2019/10/01 21:40:06 [INFO] Deleting DMS Replication Instance: arn:aws-us-gov:dms:us-gov-west-1:--OMITTED--:rep:HSISACH376XFDTHOD3QK467JO4 2019/10/01 21:41:40 [INFO] Deleting DMS Replication Instance: arn:aws-us-gov:dms:us-gov-west-1:--OMITTED--:rep:PXOZXXYRFGYODHALM7LLIVW64M 2019/10/01 21:43:34 [INFO] Deleting DMS Replication Instance: arn:aws-us-gov:dms:us-gov-west-1:--OMITTED--:rep:36TNUO2WY3OLXS76Q6UU5QDRVU 2019/10/01 21:48:45 [INFO] Deleting DMS Replication Instance: arn:aws-us-gov:dms:us-gov-west-1:--OMITTED--:rep:UPWXIGKB2U7DQGOXMF7JT6HUSA 2019/10/01 21:52:02 [INFO] Deleting DMS Replication Instance: arn:aws-us-gov:dms:us-gov-west-1:--OMITTED--:rep:NOQXOEQHBOD663OLAL7V7LJZ3Y 2019/10/01 21:53:24 [INFO] Deleting DMS Replication Instance: arn:aws-us-gov:dms:us-gov-west-1:--OMITTED--:rep:O2P4ZP3F4AYNBXJCJGQZD7QUMQ 2019/10/01 21:54:57 Sweeper Tests ran: - aws_dms_replication_instance ok github.com/terraform-providers/terraform-provider-aws/aws 1176.002s ```
Some of these expensive resources were being left, making our monthly bill much higher than it should be. Output from sweeper in AWS Commercial: ```console $ go test ./aws -v -sweep=us-east-1,us-west-2 -sweep-run=aws_sagemaker_notebook_instance -timeout 10h 2019/10/02 10:40:51 [DEBUG] Running Sweepers for region (us-east-1): ... 2019/10/02 10:40:55 [INFO] No SageMaker Notebook Instance Lifecycle Configuration to sweep 2019/10/02 10:40:55 Sweeper Tests ran: - aws_sagemaker_notebook_instance - aws_sagemaker_notebook_instance_lifecycle_configuration 2019/10/02 10:40:55 [DEBUG] Running Sweepers for region (us-west-2): ... 2019/10/02 10:40:57 [INFO] Stopping SageMaker Notebook Instance: terraform-testacc-20190111204137989200000001 2019/10/02 10:42:15 [INFO] Deleting SageMaker Notebook Instance: terraform-testacc-20190111204137989200000001 2019/10/02 10:43:22 [INFO] Stopping SageMaker Notebook Instance: terraform-testacc-20190111203020262800000001 2019/10/02 10:44:30 [INFO] Deleting SageMaker Notebook Instance: terraform-testacc-20190111203020262800000001 2019/10/02 10:45:37 [INFO] Stopping SageMaker Notebook Instance: terraform-testacc-20181107160450462100000002 2019/10/02 10:45:37 [INFO] Deleting SageMaker Notebook Instance: terraform-testacc-20181107160450462100000002 2019/10/02 10:45:42 [INFO] Stopping SageMaker Notebook Instance: terraform-testacc-20181106174217513800000002 2019/10/02 10:45:42 [INFO] Deleting SageMaker Notebook Instance: terraform-testacc-20181106174217513800000002 2019/10/02 10:45:45 [INFO] Stopping SageMaker Notebook Instance: terraform-testacc-20181102155400054000000002 2019/10/02 10:45:45 [INFO] Deleting SageMaker Notebook Instance: terraform-testacc-20181102155400054000000002 2019/10/02 10:45:48 [INFO] Stopping SageMaker Notebook Instance: terraform-testacc-20181102135150793100000002 2019/10/02 10:45:48 [INFO] Deleting SageMaker Notebook Instance: terraform-testacc-20181102135150793100000002 2019/10/02 10:45:53 [INFO] No SageMaker Notebook Instance Lifecycle Configuration to sweep 2019/10/02 10:45:53 Sweeper Tests ran: - aws_sagemaker_notebook_instance - aws_sagemaker_notebook_instance_lifecycle_configuration ok github.com/terraform-providers/terraform-provider-aws/aws 303.047s ``` Output from sweeper in AWS GovCloud (US): ```console $ go test ./aws -v -sweep=us-gov-west-1 -sweep-run=aws_sagemaker_notebook_instance -timeout 10h 2019/10/02 10:40:56 [DEBUG] Running Sweepers for region (us-gov-west-1): ... 2019/10/02 10:41:00 [INFO] No SageMaker Notebook Instance Lifecycle Configuration to sweep 2019/10/02 10:41:00 Sweeper Tests ran: - aws_sagemaker_notebook_instance_lifecycle_configuration - aws_sagemaker_notebook_instance ok github.com/terraform-providers/terraform-provider-aws/aws 5.196s ```
Reference: #10035 (review) Without the IAM SLR: ``` --- FAIL: TestAccAWSElasticSearchDomain_basic (1.41s) resource_aws_elasticsearch_domain_test.go:827: missing IAM Service Linked Role (es.amazonaws.com), please create it in the AWS account and retry ``` Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAWSElasticSearchDomain_basic (841.35s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- PASS: TestAccAWSElasticSearchDomain_basic (605.90s) ```
…nes and aws_partition data sources to make more region/partition agnostic AWS GovCloud (US) will require additional work, like changing the instance types and adding the Cognito Identity PreCheck Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAWSElasticSearchDomain_basic (718.13s) --- PASS: TestAccAWSElasticSearchDomain_policy (909.82s) --- PASS: TestAccAWSElasticSearchDomain_LogPublishingOptions (928.65s) --- PASS: TestAccAWSDataElasticsearchDomain_basic (1280.68s) --- PASS: TestAccAWSDataElasticsearchDomain_advanced (1460.89s) --- PASS: TestAccAWSElasticSearchDomain_CognitoOptionsCreateAndRemove (2027.75s) --- PASS: TestAccAWSElasticSearchDomain_CognitoOptionsUpdate (2154.32s) ```
…k to acceptance testing requiring service
Skip the test in regions where the service is not available.
Output from acceptance testing in AWS Commercial:
```
--- PASS: TestAccAWSElasticSearchDomain_CognitoOptionsCreateAndRemove (2027.75s)
--- PASS: TestAccAWSElasticSearchDomain_CognitoOptionsUpdate (2154.32s)
```
Output from acceptance testing in AWS GovCloud (US):
```
--- SKIP: TestAccAWSElasticSearchDomain_CognitoOptionsUpdate (24.17s)
resource_aws_cognito_user_pool_test.go:760: skipping acceptance testing: RequestError: send request failed
caused by: Post https://cognito-idp.us-gov-west-1.amazonaws.com/: dial tcp: lookup cognito-idp.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAWSElasticSearchDomain_CognitoOptionsCreateAndRemove (28.41s)
resource_aws_cognito_user_pool_test.go:760: skipping acceptance testing: RequestError: send request failed
caused by: Post https://cognito-idp.us-gov-west-1.amazonaws.com/: dial tcp: lookup cognito-idp.us-gov-west-1.amazonaws.com: no such host
```
… forecast, personalize, qldb, quicksight, and worklink services Reference: #10392 Some of these were likely missed because they live in the GitHub Actions pull request labeling instead of hashibot (where the original list of copy-pasted from), but others are just newer GA services.
There is no API for fetching available versions, so manually updating the test configurations. This API removal was not included in the [2.2.1 announcement](https://aws.amazon.com/about-aws/whats-new/2019/07/amazon-msk-adds-support-apache-kafka-version-221-expands-availability-stockholm-mumbai-seoul/). Previously: ``` --- FAIL: TestAccAWSMskCluster_basic (8.39s) testing.go:569: Step 0 error: errors during apply: Error: error creating MSK cluster: BadRequestException: Unsupported KafkaVersion [2.1.0]. Valid values: [1.1.1, 2.2.1] ``` Output from acceptance testing in AWS Commercial (in an account that hasn't reached the MSK Configuration quota and now correctly shows failures relating to the default encryption changing from client broker TLS_PLAINTEXT to TLS after launch): ``` --- FAIL: TestAccAWSMskCluster_basic (756.44s) testing.go:569: Step 0 error: Check failed: Check 3/27 error: aws_msk_cluster.test: Attribute 'bootstrap_brokers' didn't match "^(([-\\w]+\\.){1,}[\\w]+:\\d+,){2,}([-\\w]+\\.){1,}[\\w]+:\\d+$", got "" ```
…d m3.medium.elasticsearch instance types with those also available in AWS GovCloud (US)
t2.micro.elasticsearch and m3.medium.elasticsearch are not available in AWS GovCloud (US):
```
--- FAIL: TestAccAWSDataElasticsearchDomain_basic (11.82s)
testing.go:569: Step 0 error: errors during apply:
Error: Error creating ElasticSearch domain: InvalidTypeException: Invalid instance type: t2.micro.elasticsearch
--- FAIL: TestAccAWSElasticSearchDomain_vpc (29.57s)
testing.go:569: Step 0 error: errors during apply:
Error: Error creating ElasticSearch domain: InvalidTypeException: Invalid instance type: m3.medium.elasticsearch
```
`t2.small.elasticsearch` requires EBS:
```
--- FAIL: TestAccAWSElasticSearchDomain_vpc (27.40s)
testing.go:569: Step 0 error: errors during apply:
Error: Error creating ElasticSearch domain: ValidationException: EBS storage must be selected for t2.small.elasticsearch
```
The test failures below are unrelated and outside this timeboxed test fixing.
Output from acceptance testing in AWS Commercial:
```
--- PASS: TestAccAWSElasticSearchDomain_duplicate (474.12s)
--- PASS: TestAccAWSElasticSearchDomain_LogPublishingOptions (683.94s)
--- PASS: TestAccAWSDataElasticsearchDomain_basic (776.88s)
--- PASS: TestAccAWSElasticSearchDomain_encrypt_at_rest_default_key (1080.62s)
--- PASS: TestAccAWSElasticSearchDomain_policy (1085.77s)
--- PASS: TestAccAWSElasticSearchDomain_tags (1200.87s)
--- PASS: TestAccAWSDataElasticsearchDomain_advanced (1286.42s)
--- PASS: TestAccAWSElasticSearchDomain_encrypt_at_rest_specify_key (1359.59s)
--- PASS: TestAccAWSElasticSearchDomain_complex (863.71s)
--- PASS: TestAccAWSElasticSearchDomain_vpc (1197.43s)
--- FAIL: TestAccAWSElasticSearchDomain_update_version (1853.26s)
testing.go:569: Step 1 error: errors during apply:
Error: unexpected state '', wanted target 'SUCCEEDED'. last error: %!s(<nil>)
on /var/folders/v0/_d108fkx1pbbg4_sh864_7740000gn/T/tf-test840863232/main.tf line 2:
(source code not available)
--- PASS: TestAccAWSElasticSearchDomain_importBasic (1926.44s)
--- PASS: TestAccAWSElasticSearchDomain_v23 (1933.81s)
--- PASS: TestAccAWSElasticSearchDomain_update (2150.40s)
--- PASS: TestAccAWSElasticSearchDomain_basic (1572.62s)
--- PASS: TestAccAWSElasticSearchDomain_internetToVpcEndpoint (2532.29s)
--- PASS: TestAccAWSElasticSearchDomain_CognitoOptionsCreateAndRemove (2569.90s)
--- PASS: TestAccAWSElasticSearchDomain_NodeToNodeEncryption (2828.32s)
--- PASS: TestAccAWSElasticSearchDomain_vpc_update (2847.08s)
--- PASS: TestAccAWSElasticSearchDomain_withDedicatedMaster (3432.49s)
--- PASS: TestAccAWSElasticSearchDomain_update_volume_type (3918.28s)
--- PASS: TestAccAWSElasticSearchDomain_CognitoOptionsUpdate (4135.44s)
--- PASS: TestAccAWSElasticSearchDomain_ClusterConfig_ZoneAwarenessConfig (4836.72s)
```
Output from acceptance testing in AWS GovCloud (US):
```
--- SKIP: TestAccAWSElasticSearchDomain_CognitoOptionsUpdate (23.74s)
resource_aws_cognito_user_pool_test.go:760: skipping acceptance testing: RequestError: send request failed
caused by: Post https://cognito-idp.us-gov-west-1.amazonaws.com/: dial tcp: lookup cognito-idp.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAWSElasticSearchDomain_CognitoOptionsCreateAndRemove (29.73s)
resource_aws_cognito_user_pool_test.go:760: skipping acceptance testing: RequestError: send request failed
caused by: Post https://cognito-idp.us-gov-west-1.amazonaws.com/: dial tcp: lookup cognito-idp.us-gov-west-1.amazonaws.com: no such host
--- PASS: TestAccAWSElasticSearchDomain_duplicate (396.68s)
--- PASS: TestAccAWSElasticSearchDomain_complex (635.22s)
--- PASS: TestAccAWSElasticSearchDomain_policy (636.07s)
--- PASS: TestAccAWSElasticSearchDomain_NodeToNodeEncryption (705.29s)
--- PASS: TestAccAWSElasticSearchDomain_v23 (702.20s)
--- PASS: TestAccAWSDataElasticsearchDomain_basic (755.19s)
--- FAIL: TestAccAWSElasticSearchDomain_update_version (900.69s)
testing.go:569: Step 1 error: Check failed: Check 3/3 error: aws_elasticsearch_domain.example: Attribute 'elasticsearch_version' expected "5.6", got "5.5"
--- PASS: TestAccAWSElasticSearchDomain_importBasic (879.55s)
--- PASS: TestAccAWSElasticSearchDomain_basic (1091.51s)
--- PASS: TestAccAWSElasticSearchDomain_encrypt_at_rest_specify_key (1117.72s)
--- PASS: TestAccAWSElasticSearchDomain_LogPublishingOptions (1135.15s)
--- PASS: TestAccAWSElasticSearchDomain_vpc (1143.39s)
--- PASS: TestAccAWSElasticSearchDomain_tags (1147.12s)
--- PASS: TestAccAWSDataElasticsearchDomain_advanced (1173.96s)
--- PASS: TestAccAWSElasticSearchDomain_internetToVpcEndpoint (1603.77s)
--- PASS: TestAccAWSElasticSearchDomain_vpc_update (1918.00s)
--- PASS: TestAccAWSElasticSearchDomain_update_volume_type (2939.14s)
--- PASS: TestAccAWSElasticSearchDomain_withDedicatedMaster (3658.41s)
```
In situations where Terraform needs to replace an aws_emr_cluster resource that has aws_emr_instance_group resources associated with it, Terraform tries to execute a destroy on the instance group, but it fails as the notion of a "destroy" on an instance group is to set the number of instances to zero, but AWS doesn't let you modify the count of instances in an instance group on an EMR cluster. This fixes the issue by treating an instance group that has been terminated as no longer existing, so Terraform won't try to execute a "destroy" and not error out. Fixes #1355 Fixes #9400
This adds a configurations_json property for the aws_emr_instance_group resource similar to the configurations_json property for the aws_emr_cluster resource as they are processed the same by AWS. Fixes #9342
Update module hashicorp/aws-sdk-go-base to v0.4.0
…ion due to instance type unavailability
Previously, could receive these errors:
```
--- FAIL: TestAccAWSStorageGatewayGateway_GatewayName (19.06s)
testing.go:569: Step 0 error: errors during apply:
Error: Error launching source instance: Unsupported: Your requested instance type (m4.xlarge) is not supported in your requested Availability Zone (us-west-2d). Please retry your request by not specifying an Availability Zone or choosing us-west-2a, us-west-2b, us-west-2c.
--- FAIL: TestAccAWSStorageGatewayNfsFileShare_basic (19.07s)
testing.go:569: Step 0 error: errors during apply:
Error: Error launching source instance: Unsupported: Your requested instance type (m4.xlarge) is not supported in your requested Availability Zone (us-west-2d). Please retry your request by not specifying an Availability Zone or choosing us-west-2a, us-west-2b, us-west-2c.
```
Output from acceptance testing (one unrelated failure):
```
--- SKIP: TestAccAWSStorageGatewayCachedIscsiVolume_SourceVolumeArn (0.00s)
--- PASS: TestAccAWSStorageGatewayLocalDiskDataSource_DiskNode (147.71s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_basic (163.73s)
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_Cached (211.47s)
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_Stored (212.70s)
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_Vtl (218.82s)
--- PASS: TestAccAWSStorageGatewayCache_TapeAndVolumeGateway (229.49s)
--- PASS: TestAccAWSStorageGatewayGateway_SmbGuestPassword (230.27s)
--- PASS: TestAccAWSStorageGatewayCachedIscsiVolume_SnapshotId (234.99s)
--- PASS: TestAccAWSStorageGatewayCachedIscsiVolume_Basic (235.95s)
--- FAIL: TestAccAWSStorageGatewayCache_FileGateway (243.30s)
testing.go:569: Step 0 error: After applying this step, the plan was not empty:
DIFF:
DESTROY/CREATE: aws_storagegateway_cache.test
disk_id: "1236ea07-49f2-4a5f-a1ca-9946a412c0b4" => "/dev/xvdb" (forces new resource)
gateway_arn: "arn:aws:storagegateway:us-west-2:*******:gateway/sgw-F532DE9C" => "arn:aws:storagegateway:us-west-2:*******:gateway/sgw-F532DE9C"
id: "arn:aws:storagegateway:us-west-2:*******:gateway/sgw-F532DE9C:1236ea07-49f2-4a5f-a1ca-9946a412c0b4" => "<computed>"
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_FileS3 (276.81s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_DefaultStorageClass (280.34s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_KMSEncrypted (298.93s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_KMSKeyArn (317.55s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_ClientList (346.94s)
--- PASS: TestAccAWSStorageGatewayLocalDiskDataSource_DiskPath (379.81s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_NFSFileShareDefaults (243.49s)
--- PASS: TestAccAWSStorageGatewayGateway_GatewayName (405.04s)
--- PASS: TestAccAWSStorageGatewayGateway_GatewayTimezone (413.34s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_Authentication_GuestAccess (221.46s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_GuessMIMETypeEnabled (475.32s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_ReadOnly (289.72s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_KMSEncrypted (234.47s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_RequesterPays (312.04s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_DefaultStorageClass (296.97s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_ReadOnly (260.51s)
--- PASS: TestAccAWSStorageGatewayUploadBuffer_Basic (227.74s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_KMSKeyArn (340.45s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_RequesterPays (300.51s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_ObjectACL (476.09s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_GuessMIMETypeEnabled (468.50s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_Squash (487.55s)
--- PASS: TestAccAWSStorageGatewayWorkingStorage_Basic (306.62s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_ObjectACL (468.39s)
--- PASS: TestAccAWSStorageGatewayGateway_SmbActiveDirectorySettings (807.33s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_ValidUserList (775.94s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_Authentication_ActiveDirectory (951.58s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_InvalidUserList (1095.85s)
```
…m-aws-aws-sdk-go-1.x Update module aws/aws-sdk-go to v1.25.10
…m-hashicorp-terraform-plugin-sdk-1.x Update module hashicorp/terraform-plugin-sdk to v1.1.1
* github/workflows/issues: Add Actions Token * github/workflows/issues: Update project automation action version
- Using go-sdk constants
- Running, fixing and cleaning tests
Here's my current test output
``` bash
AWS_DEFAULT_REGION=us-east-1 AWS_PROFILE=default TF_ACC=1 go test ./aws -v -timeout 120m -parallel 20 -run='TestAccAWSQuickSightUser_'
```
> go: finding github.com/terraform-providers/terraform-provider-tls
> v2.1.1+incompatible
> go: finding github.com/terraform-providers/terraform-provider-tls
> v2.1.1+incompatible
> === RUN TestAccAWSQuickSightUser_basic
> === PAUSE TestAccAWSQuickSightUser_basic
> === RUN TestAccAWSQuickSightUser_withInvalidFormattedEmailStillWorks
> === PAUSE TestAccAWSQuickSightUser_withInvalidFormattedEmailStillWorks
> === RUN TestAccAWSQuickSightUser_disappears
> === PAUSE TestAccAWSQuickSightUser_disappears
> === CONT TestAccAWSQuickSightUser_basic
> === CONT TestAccAWSQuickSightUser_disappears
> === CONT TestAccAWSQuickSightUser_withInvalidFormattedEmailStillWorks
> --- PASS: TestAccAWSQuickSightUser_disappears (14.19s)
> --- PASS: TestAccAWSQuickSightUser_basic (25.44s)
> --- PASS: TestAccAWSQuickSightUser_withInvalidFormattedEmailStillWorks
> (26.08s)
> PASS
> ok github.com/terraform-providers/terraform-provider-aws/aws
> 26.109s
Note that the tests exposed that the `describe-user` QuickSight API does
not return the schema that is documented.
For example, when I run it via the CLI I get
``` json
{
"RequestId": "some-guid-looking-thing",
"Status": 200,
"User": {
"Arn":
"arn:aws:quicksight:us-west-2:01234567890:user/default/some_user",
"PrincipalId": "federated/iam/some_user",
"Email": "someemail@pfake.com",
"Active": true,
"Role": "ADMIN",
"UserName": "some_user"
}
}
```
Notice that `IdentityType` is missing though documented!
This means that I had to remove it from attributes and remove the
importer :( since we can't reconcile that value.
If there's a way around this please let me know.
Also note that I couldn't use `acctest.RandomWithPrefix` because the
resultant username was not valid in QuickSight.
Remove GitHub Action for PR labeling
…et-timeouts resource/aws_gamelift_fleet: Increase default deletion timeout to 20 minutes, add missing timeouts documentation
…lacklist-usw2-az4 tests/service/storagegateway: Blacklist usw2-az4 from test configuration due to instance type unavailability
…tebook_instance-sweeper tests/resource/aws_sagemaker_notebook_instance: Add sweeper
…ion_instance-sweeper tests/resource/aws_dms_replication_instance: Add sweeper
Add WAF rate based rule data source
…sed-rule Add WAF regional rate based rule data source
Add quicksight user resource
DrFaust92
pushed a commit
that referenced
this pull request
Jun 13, 2020
fixing retry logic - DescribeTags returns no err and an empty list of…
DrFaust92
pushed a commit
that referenced
this pull request
Sep 3, 2020
Merging master into feature branch
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates OR Closes #0000
Release note for CHANGELOG:
Output from acceptance testing: