Refactor r/aws_acmpca_certificate_authority to use keyvaluetags

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #10688

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAwsAcmpcaCertificateAuthority_'
--- PASS: TestAccAwsAcmpcaCertificateAuthority_Basic (83.26s)
--- FAIL: TestAccAwsAcmpcaCertificateAuthority_RevocationConfiguration_CrlConfiguration_CustomCname (40.89s)
    testing.go:615: Step 0 error: errors during apply:
        
        Error: Error creating S3 bucket: BucketAlreadyOwnedByYou: Your previous request to create the named bucket succeeded and you already own it.
        	status code: 409
TestAccAwsAcmpcaCertificateAuthority_RevocationConfiguration_CrlConfiguration_Enabled
--- PASS: TestAccAwsAcmpcaCertificateAuthority_RevocationConfiguration_CrlConfiguration_Enabled (541.26s)
TestAccAwsAcmpcaCertificateAuthority_RevocationConfiguration_CrlConfiguration_ExpirationInDays
--- PASS: TestAccAwsAcmpcaCertificateAuthority_RevocationConfiguration_CrlConfiguration_ExpirationInDays (436.56s)
--- PASS: TestAccAwsAcmpcaCertificateAuthority_Tags (336.13s)
--- PASS: TestAccAwsAcmpcaCertificateAuthority_Type_Root (75.95s)

...

there a test that fail on a duplicate bucket, probably an issue of concurrency of tests i guess

[bflad]

Looks great, thanks @DrFaust92 🚀 Also will note in the changelog the new support for tagging on creation, which I verified is also available in AWS GovCloud (US) so we can get this in without extra effort.

Output from acceptance test from AWS Commercial:

--- PASS: TestAccAwsAcmpcaCertificateAuthority_Type_Root (10.15s)
--- PASS: TestAccAwsAcmpcaCertificateAuthority_Basic (10.98s)
--- PASS: TestAccAwsAcmpcaCertificateAuthority_RevocationConfiguration_CrlConfiguration_ExpirationInDays (26.15s)
--- PASS: TestAccAwsAcmpcaCertificateAuthority_Tags (26.89s)
--- PASS: TestAccAwsAcmpcaCertificateAuthority_RevocationConfiguration_CrlConfiguration_Enabled (32.01s)
--- PASS: TestAccAwsAcmpcaCertificateAuthority_RevocationConfiguration_CrlConfiguration_CustomCname (38.91s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAwsAcmpcaCertificateAuthority_Basic (6.80s)
--- PASS: TestAccAwsAcmpcaCertificateAuthority_Type_Root (7.28s)
--- PASS: TestAccAwsAcmpcaCertificateAuthority_RevocationConfiguration_CrlConfiguration_ExpirationInDays (13.45s)
--- PASS: TestAccAwsAcmpcaCertificateAuthority_Tags (13.92s)
--- PASS: TestAccAwsAcmpcaCertificateAuthority_RevocationConfiguration_CrlConfiguration_Enabled (16.07s)
--- PASS: TestAccAwsAcmpcaCertificateAuthority_RevocationConfiguration_CrlConfiguration_CustomCname (17.68s)

[ghost]

This has been released in version 2.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!