resource/aws_vpc: Add support for classiclink_dns_support #1079
Conversation
Fixes: #1076 ``` % make testacc TEST=./aws TESTARGS='-run=TestAccAWSVpc' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -run=TestAccAWSVpc -timeout 120m === RUN TestAccAWSVpcEndpoint_importBasic --- PASS: TestAccAWSVpcEndpoint_importBasic (68.54s) === RUN TestAccAWSVpc_importBasic --- PASS: TestAccAWSVpc_importBasic (53.29s) === RUN TestAccAWSVpcEndpointRouteTableAssociation_basic --- PASS: TestAccAWSVpcEndpointRouteTableAssociation_basic (59.57s) === RUN TestAccAWSVpcEndpoint_basic --- PASS: TestAccAWSVpcEndpoint_basic (58.48s) === RUN TestAccAWSVpcEndpoint_withRouteTableAndPolicy --- PASS: TestAccAWSVpcEndpoint_withRouteTableAndPolicy (117.51s) === RUN TestAccAWSVpcEndpoint_WithoutRouteTableOrPolicyConfig --- PASS: TestAccAWSVpcEndpoint_WithoutRouteTableOrPolicyConfig (53.33s) === RUN TestAccAWSVpcEndpoint_removed --- PASS: TestAccAWSVpcEndpoint_removed (49.14s) === RUN TestAccAWSVpc_basic --- PASS: TestAccAWSVpc_basic (45.19s) === RUN TestAccAWSVpc_enableIpv6 --- PASS: TestAccAWSVpc_enableIpv6 (132.93s) === RUN TestAccAWSVpc_dedicatedTenancy --- PASS: TestAccAWSVpc_dedicatedTenancy (46.52s) === RUN TestAccAWSVpc_tags --- PASS: TestAccAWSVpc_tags (87.11s) === RUN TestAccAWSVpc_update --- PASS: TestAccAWSVpc_update (85.61s) === RUN TestAccAWSVpc_DisabledDnsSupport --- PASS: TestAccAWSVpc_DisabledDnsSupport (43.34s) === RUN TestAccAWSVpc_classiclinkOptionSet --- PASS: TestAccAWSVpc_classiclinkOptionSet (45.99s) === RUN TestAccAWSVpc_classiclinkDnsSupportOptionSet --- PASS: TestAccAWSVpc_classiclinkDnsSupportOptionSet (52.46s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 1009.082s ```
stack72
added
the
enhancement
| log.Printf("[WARN] VPC Classic Link DNS Support is not supported in this region") | ||
| } else { | ||
| return err | ||
| } |
There was a problem hiding this comment.
Should we default this value to false? It looks like here in the error case the value will not get set at all (d.Set only called in the else clause here). I'm imagining a situation where a user has an account/region that doesn't support this, they try to enable it with true here, it fails, but we never set it ourselves to false and so they end up with true in the state file, which doesn't reflect reality. Is that possible or am I missing something?
There was a problem hiding this comment.
This follows exactly the same pattern as enable_classiclink - that seems to work well so therefore, we don't set it to default - thoughts?
| log.Printf("[WARN] VPC Classic Link DNS Support is not supported in this region") | ||
| } else { | ||
| return err | ||
| } |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Fixes: #1076