Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/d-launch_configuration-arn addition #11416

Merged
merged 1 commit into from
Jan 2, 2020
Merged

r/d-launch_configuration-arn addition #11416

merged 1 commit into from
Jan 2, 2020

Conversation

thatderek
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #10858

Release note for CHANGELOG:

* resource/aws_launch_configuration: Makes `arn` of cluster available as resource attribute. [GH-10858]
* data/aws_launch_configuration: Makes `arn` of cluster available as resource attribute. [GH-10858]

Output from acceptance testing:

root@916d62d75b44:/go/src/github.com/terraform-providers/terraform-provider-aws# AWS_PROFILE=default make testacc test=./aws TESTARGS='-run=TestAccAWSLaunchConfiguration_'     
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSLaunchConfiguration_ -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSLaunchConfiguration_basic
=== PAUSE TestAccAWSLaunchConfiguration_basic
=== RUN   TestAccAWSLaunchConfiguration_withBlockDevices
=== PAUSE TestAccAWSLaunchConfiguration_withBlockDevices
=== RUN   TestAccAWSLaunchConfiguration_updateRootBlockDevice
=== PAUSE TestAccAWSLaunchConfiguration_updateRootBlockDevice
=== RUN   TestAccAWSLaunchConfiguration_encryptedRootBlockDevice
=== PAUSE TestAccAWSLaunchConfiguration_encryptedRootBlockDevice
=== RUN   TestAccAWSLaunchConfiguration_withSpotPrice
=== PAUSE TestAccAWSLaunchConfiguration_withSpotPrice
=== RUN   TestAccAWSLaunchConfiguration_withVpcClassicLink
=== PAUSE TestAccAWSLaunchConfiguration_withVpcClassicLink
=== RUN   TestAccAWSLaunchConfiguration_withIAMProfile
=== PAUSE TestAccAWSLaunchConfiguration_withIAMProfile
=== RUN   TestAccAWSLaunchConfiguration_withEncryption
=== PAUSE TestAccAWSLaunchConfiguration_withEncryption
=== RUN   TestAccAWSLaunchConfiguration_updateEbsBlockDevices
=== PAUSE TestAccAWSLaunchConfiguration_updateEbsBlockDevices
=== RUN   TestAccAWSLaunchConfiguration_ebs_noDevice
=== PAUSE TestAccAWSLaunchConfiguration_ebs_noDevice
=== RUN   TestAccAWSLaunchConfiguration_userData
=== PAUSE TestAccAWSLaunchConfiguration_userData
=== CONT  TestAccAWSLaunchConfiguration_basic
=== CONT  TestAccAWSLaunchConfiguration_withEncryption
=== CONT  TestAccAWSLaunchConfiguration_userData
=== CONT  TestAccAWSLaunchConfiguration_withSpotPrice
=== CONT  TestAccAWSLaunchConfiguration_withIAMProfile
=== CONT  TestAccAWSLaunchConfiguration_ebs_noDevice
=== CONT  TestAccAWSLaunchConfiguration_updateRootBlockDevice
=== CONT  TestAccAWSLaunchConfiguration_withVpcClassicLink
=== CONT  TestAccAWSLaunchConfiguration_encryptedRootBlockDevice
=== CONT  TestAccAWSLaunchConfiguration_withBlockDevices
=== CONT  TestAccAWSLaunchConfiguration_updateEbsBlockDevices
--- PASS: TestAccAWSLaunchConfiguration_withSpotPrice (31.93s)
--- PASS: TestAccAWSLaunchConfiguration_ebs_noDevice (33.64s)
--- PASS: TestAccAWSLaunchConfiguration_withBlockDevices (33.84s)
--- PASS: TestAccAWSLaunchConfiguration_withEncryption (35.05s)
--- PASS: TestAccAWSLaunchConfiguration_encryptedRootBlockDevice (55.17s)
--- PASS: TestAccAWSLaunchConfiguration_withIAMProfile (59.38s)
--- PASS: TestAccAWSLaunchConfiguration_withVpcClassicLink (61.38s)
--- PASS: TestAccAWSLaunchConfiguration_userData (63.37s)
--- PASS: TestAccAWSLaunchConfiguration_basic (63.38s)
--- PASS: TestAccAWSLaunchConfiguration_updateEbsBlockDevices (67.51s)
--- PASS: TestAccAWSLaunchConfiguration_updateRootBlockDevice (68.08s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	68.139s
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/flatmap	0.010s [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/keyvaluetags	0.050s [no tests to run]
root@916d62d75b44:/go/src/github.com/terraform-providers/terraform-provider-aws# AWS_PROFILE=default make testacc test=./aws TESTARGS='-run=TestAccAWSLaunchConfigurationDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSLaunchConfigurationDataSource_ -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSLaunchConfigurationDataSource_basic
=== PAUSE TestAccAWSLaunchConfigurationDataSource_basic
=== RUN   TestAccAWSLaunchConfigurationDataSource_securityGroups
=== PAUSE TestAccAWSLaunchConfigurationDataSource_securityGroups
=== CONT  TestAccAWSLaunchConfigurationDataSource_basic
=== CONT  TestAccAWSLaunchConfigurationDataSource_securityGroups
--- PASS: TestAccAWSLaunchConfigurationDataSource_basic (31.58s)
--- PASS: TestAccAWSLaunchConfigurationDataSource_securityGroups (46.65s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	46.687s
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/flatmap	0.034s [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/keyvaluetags	0.004s [no tests to run]
root@916d62d75b44:/go/src/github.com/terraform-providers/terraform-provider-aws#

@thatderek thatderek requested a review from a team December 23, 2019 18:17
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/autoscaling Issues and PRs that pertain to the autoscaling service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Dec 23, 2019
bflad
bflad suggested changes Jan 2, 2020
View reviewed changes
Copy link
Member

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting this, @thatderek -- one small change and this should be good to go. 👍

Output from acceptance testing:

--- PASS: TestAccAWSLaunchConfigurationDataSource_basic (14.89s)
--- PASS: TestAccAWSLaunchConfiguration_withVpcClassicLink (19.88s)
--- PASS: TestAccAWSLaunchConfiguration_encryptedRootBlockDevice (20.67s)
--- PASS: TestAccAWSLaunchConfiguration_withSpotPrice (21.66s)
--- PASS: TestAccAWSLaunchConfiguration_withEncryption (24.70s)
--- PASS: TestAccAWSLaunchConfiguration_updateRootBlockDevice (25.91s)
--- PASS: TestAccAWSLaunchConfiguration_ebs_noDevice (26.87s)
--- PASS: TestAccAWSLaunchConfiguration_updateEbsBlockDevices (29.18s)
--- PASS: TestAccAWSLaunchConfiguration_withIAMProfile (31.33s)
--- PASS: TestAccAWSLaunchConfiguration_basic (31.63s)
--- PASS: TestAccAWSLaunchConfigurationDataSource_securityGroups (32.58s)
--- PASS: TestAccAWSLaunchConfiguration_withBlockDevices (34.20s)
--- PASS: TestAccAWSLaunchConfiguration_userData (34.65s)

aws/resource_aws_launch_configuration.go Outdated Show resolved Hide resolved
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. waiting-response Maintainers are waiting on response from community or contributor. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 2, 2020
@thatderek thatderek force-pushed the r-aws_launch_configuration-arn branch from c55d64f to a7c5975 Compare January 2, 2020 16:46
@thatderek
Copy link
Contributor Author

post @bflad 's change req:

--- PASS: TestAccAWSLaunchConfiguration_withSpotPrice (31.29s)
--- PASS: TestAccAWSLaunchConfiguration_ebs_noDevice (32.57s)
--- PASS: TestAccAWSLaunchConfiguration_withBlockDevices (33.26s)
--- PASS: TestAccAWSLaunchConfiguration_withEncryption (33.46s)
--- PASS: TestAccAWSLaunchConfiguration_withIAMProfile (42.88s)
--- PASS: TestAccAWSLaunchConfiguration_encryptedRootBlockDevice (46.21s)
--- PASS: TestAccAWSLaunchConfiguration_withVpcClassicLink (51.88s)
--- PASS: TestAccAWSLaunchConfiguration_userData (52.52s)
--- PASS: TestAccAWSLaunchConfiguration_basic (63.41s)
--- PASS: TestAccAWSLaunchConfiguration_updateRootBlockDevice (66.91s)
--- PASS: TestAccAWSLaunchConfiguration_updateEbsBlockDevices (67.02s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	67.100s

@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Jan 2, 2020
@thatderek thatderek requested a review from bflad January 2, 2020 16:48
@bflad bflad added this to the v2.44.0 milestone Jan 2, 2020
bflad
bflad approved these changes Jan 2, 2020
View reviewed changes
Copy link
Member

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @thatderek 🚀

Output from acceptance testing:

--- PASS: TestAccAWSLaunchConfigurationDataSource_basic (14.82s)
--- PASS: TestAccAWSLaunchConfiguration_withEncryption (14.72s)
--- PASS: TestAccAWSLaunchConfiguration_withBlockDevices (16.99s)
--- PASS: TestAccAWSLaunchConfiguration_encryptedRootBlockDevice (20.22s)
--- PASS: TestAccAWSLaunchConfigurationDataSource_securityGroups (20.87s)
--- PASS: TestAccAWSLaunchConfiguration_withVpcClassicLink (23.57s)
--- PASS: TestAccAWSLaunchConfiguration_ebs_noDevice (24.07s)
--- PASS: TestAccAWSLaunchConfiguration_basic (25.68s)
--- PASS: TestAccAWSLaunchConfiguration_updateRootBlockDevice (27.50s)
--- PASS: TestAccAWSLaunchConfiguration_withIAMProfile (29.28s)
--- PASS: TestAccAWSLaunchConfiguration_updateEbsBlockDevices (31.88s)
--- PASS: TestAccAWSLaunchConfiguration_withSpotPrice (35.01s)
--- PASS: TestAccAWSLaunchConfiguration_userData (40.87s)

@bflad bflad merged commit dbc4baa into hashicorp:master Jan 2, 2020
bflad added a commit that referenced this pull request Jan 2, 2020
@bflad
Update CHANGELOG for #11416
60f51ed
@ghost
Copy link

ghost commented Jan 10, 2020

This has been released in version 2.44.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/autoscaling Issues and PRs that pertain to the autoscaling service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.44.0
Development

Successfully merging this pull request may close these issues.

aws_launch_configuration: it will be good to have arn on terraform state file
2 participants
@thatderek @bflad