Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for resource_aws_glub_job notification_property and notify_delay_after #12115

Merged
merged 1 commit into from
Feb 21, 2020

Conversation

jhole89
Copy link
Contributor

@jhole89 jhole89 commented Feb 21, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #11829

Release note for CHANGELOG:

resource_aws_glue_job: add notification_property & notify_delay_after support

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSGlueJob_'
--- PASS: TestAccAWSGlueJob_Basic (55.50s)
--- PASS: TestAccAWSGlueJob_ExecutionProperty (94.04s)
--- PASS: TestAccAWSGlueJob_DefaultArguments (94.87s)
--- PASS: TestAccAWSGlueJob_SecurityConfiguration (101.95s)
--- PASS: TestAccAWSGlueJob_Command (108.07s)
--- PASS: TestAccAWSGlueJob_MaxRetries (108.99s)
--- PASS: TestAccAWSGlueJob_Timeout (119.64s)
--- PASS: TestAccAWSGlueJob_AllocatedCapacity (125.96s)
--- PASS: TestAccAWSGlueJob_PythonShell (136.50s)
--- PASS: TestAccAWSGlueJob_GlueVersion (151.28s)
--- PASS: TestAccAWSGlueJob_MaxCapacity (151.92s)
--- PASS: TestAccAWSGlueJob_Description (163.76s)
--- PASS: TestAccAWSGlueJob_Tags (167.47s)
--- PASS: TestAccAWSGlueJob_WorkerType (182.65s)
--- PASS: TestAccAWSGlueJob_NotificationProperty (227.99s)

@jhole89 jhole89 requested a review from a team February 21, 2020 04:51
@ghost ghost added size/M Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/glue Issues and PRs that pertain to the glue service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 21, 2020
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 21, 2020
@bflad bflad self-assigned this Feb 21, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @jhole89 🚀

Output from acceptance testing:

--- PASS: TestAccAWSGlueJob_Basic (30.88s)
--- PASS: TestAccAWSGlueJob_SecurityConfiguration (36.97s)
--- PASS: TestAccAWSGlueJob_DefaultArguments (45.29s)
--- PASS: TestAccAWSGlueJob_AllocatedCapacity (76.75s)
--- PASS: TestAccAWSGlueJob_MaxCapacity (84.29s)
--- PASS: TestAccAWSGlueJob_Command (87.55s)
--- PASS: TestAccAWSGlueJob_Description (89.99s)
--- PASS: TestAccAWSGlueJob_Timeout (91.47s)
--- PASS: TestAccAWSGlueJob_Tags (117.69s)
--- PASS: TestAccAWSGlueJob_MaxRetries (125.08s)
--- PASS: TestAccAWSGlueJob_GlueVersion (133.45s)
--- PASS: TestAccAWSGlueJob_NotificationProperty (138.87s)
--- PASS: TestAccAWSGlueJob_PythonShell (141.05s)
--- PASS: TestAccAWSGlueJob_WorkerType (150.84s)
--- PASS: TestAccAWSGlueJob_ExecutionProperty (154.12s)

@bflad bflad added this to the v2.51.0 milestone Feb 21, 2020
@bflad bflad merged commit e30cdc9 into hashicorp:master Feb 21, 2020
bflad added a commit that referenced this pull request Feb 21, 2020
@ghost
Copy link

ghost commented Feb 28, 2020

This has been released in version 2.51.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/glue Issues and PRs that pertain to the glue service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for AWS Glue Job Notification Delay
2 participants