Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set AWS Config Configuration recorder & Delivery channel names as ForceNew #1247

Merged
merged 1 commit into from
Jul 27, 2017

Conversation

Ninir
Copy link
Contributor

@Ninir Ninir commented Jul 26, 2017

As per the documentation, AWS Config Delivery channel & Configuration recorder name attributes cannot be changed once set.

AWS Config Delivery Channel quote (documentation)

By default, AWS Config assigns the name "default" when creating the delivery channel. To change the delivery channel name, you must use the DeleteDeliveryChannel action to delete your current delivery channel, and then you must use the PutDeliveryChannel command to create a delivery channel that has the desired name.

Config Configuration Recorder quote (documentation)

By default, AWS Config automatically assigns the name "default" when creating the configuration recorder. You cannot change the assigned name.

Fixes #1244

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSConfig'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSConfig -timeout 120m
=== RUN   TestAccAWSConfig
=== RUN   TestAccAWSConfig/Config
=== RUN   TestAccAWSConfig/Config/basic
=== RUN   TestAccAWSConfig/Config/ownerAws
=== RUN   TestAccAWSConfig/Config/customlambda
=== RUN   TestAccAWSConfig/Config/importAws
=== RUN   TestAccAWSConfig/Config/importLambda
=== RUN   TestAccAWSConfig/ConfigurationRecorderStatus
=== RUN   TestAccAWSConfig/ConfigurationRecorderStatus/basic
=== RUN   TestAccAWSConfig/ConfigurationRecorderStatus/startEnabled
=== RUN   TestAccAWSConfig/ConfigurationRecorderStatus/importBasic
=== RUN   TestAccAWSConfig/ConfigurationRecorder
=== RUN   TestAccAWSConfig/ConfigurationRecorder/importBasic
=== RUN   TestAccAWSConfig/ConfigurationRecorder/basic
=== RUN   TestAccAWSConfig/ConfigurationRecorder/allParams
=== RUN   TestAccAWSConfig/DeliveryChannel
=== RUN   TestAccAWSConfig/DeliveryChannel/allParams
=== RUN   TestAccAWSConfig/DeliveryChannel/importBasic
=== RUN   TestAccAWSConfig/DeliveryChannel/basic
--- PASS: TestAccAWSConfig (1471.07s)
    --- PASS: TestAccAWSConfig/Config (689.47s)
        --- PASS: TestAccAWSConfig/Config/basic (117.88s)
        --- PASS: TestAccAWSConfig/Config/ownerAws (123.45s)
        --- PASS: TestAccAWSConfig/Config/customlambda (161.84s)
        --- PASS: TestAccAWSConfig/Config/importAws (118.49s)
        --- PASS: TestAccAWSConfig/Config/importLambda (167.82s)
    --- PASS: TestAccAWSConfig/ConfigurationRecorderStatus (276.61s)
        --- PASS: TestAccAWSConfig/ConfigurationRecorderStatus/basic (70.03s)
        --- PASS: TestAccAWSConfig/ConfigurationRecorderStatus/startEnabled (141.84s)
        --- PASS: TestAccAWSConfig/ConfigurationRecorderStatus/importBasic (64.75s)
    --- PASS: TestAccAWSConfig/ConfigurationRecorder (209.10s)
        --- PASS: TestAccAWSConfig/ConfigurationRecorder/importBasic (64.31s)
        --- PASS: TestAccAWSConfig/ConfigurationRecorder/basic (72.20s)
        --- PASS: TestAccAWSConfig/ConfigurationRecorder/allParams (72.59s)
    --- PASS: TestAccAWSConfig/DeliveryChannel (295.89s)
        --- PASS: TestAccAWSConfig/DeliveryChannel/allParams (105.68s)
        --- PASS: TestAccAWSConfig/DeliveryChannel/importBasic (107.22s)
        --- PASS: TestAccAWSConfig/DeliveryChannel/basic (82.99s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1471.097s

@Ninir Ninir force-pushed the f-config-immutable-names-1244 branch from f0c305c to 0cc5f73 Compare July 26, 2017 16:20
@Ninir Ninir added the bug Addresses a defect in current functionality. label Jul 26, 2017
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on quoting the relevant parts of the docs ❤️ and answering my questions before I ask them 😄

And thanks for fixing my mistake 👍
I don't know why did I not make these ForceNew in the initial implementation. 🤷‍♂️

@Ninir
Copy link
Contributor Author

Ninir commented Jul 27, 2017

😄

@Ninir Ninir merged commit e42ae5f into hashicorp:master Jul 27, 2017
@Ninir Ninir deleted the f-config-immutable-names-1244 branch July 27, 2017 08:51
@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS Config Configuration Recorder / Delivery Channel Names Cannot be Modified
2 participants