r/elastic_transcoder_pipeline - remove getStringPtr calls + refactor tests

[DrFaust92]

refactor tests
add disappearing test case

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #5983

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSElasticTranscoderPipeline_'
--- PASS: TestAccAWSElasticTranscoderPipeline_kmsKey (110.34s)
--- PASS: TestAccAWSElasticTranscoderPipeline_notifications (134.81s)
--- PASS: TestAccAWSElasticTranscoderPipeline_withContentConfig (136.03s)
--- PASS: TestAccAWSElasticTranscoderPipeline_withPermissions (105.47s)
--- PASS: TestAccAWSElasticTranscoderPipeline_basic (84.11s)
--- PASS: TestAccAWSElasticTranscoderPipeline_disappears (77.33s)

[ewbankkit]

Verified acceptance tests:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSElasticTranscoderPipeline_' 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSElasticTranscoderPipeline_ -timeout 120m
=== RUN   TestAccAWSElasticTranscoderPipeline_basic
=== PAUSE TestAccAWSElasticTranscoderPipeline_basic
=== RUN   TestAccAWSElasticTranscoderPipeline_kmsKey
=== PAUSE TestAccAWSElasticTranscoderPipeline_kmsKey
=== RUN   TestAccAWSElasticTranscoderPipeline_notifications
=== PAUSE TestAccAWSElasticTranscoderPipeline_notifications
=== RUN   TestAccAWSElasticTranscoderPipeline_withContentConfig
=== PAUSE TestAccAWSElasticTranscoderPipeline_withContentConfig
=== RUN   TestAccAWSElasticTranscoderPipeline_withPermissions
=== PAUSE TestAccAWSElasticTranscoderPipeline_withPermissions
=== RUN   TestAccAWSElasticTranscoderPipeline_disappears
=== PAUSE TestAccAWSElasticTranscoderPipeline_disappears
=== CONT  TestAccAWSElasticTranscoderPipeline_basic
=== CONT  TestAccAWSElasticTranscoderPipeline_withPermissions
=== CONT  TestAccAWSElasticTranscoderPipeline_disappears
=== CONT  TestAccAWSElasticTranscoderPipeline_notifications
=== CONT  TestAccAWSElasticTranscoderPipeline_withContentConfig
=== CONT  TestAccAWSElasticTranscoderPipeline_kmsKey
--- PASS: TestAccAWSElasticTranscoderPipeline_disappears (38.15s)
--- PASS: TestAccAWSElasticTranscoderPipeline_withPermissions (47.10s)
--- PASS: TestAccAWSElasticTranscoderPipeline_kmsKey (62.83s)
--- PASS: TestAccAWSElasticTranscoderPipeline_notifications (67.19s)
--- PASS: TestAccAWSElasticTranscoderPipeline_withContentConfig (67.80s)
--- PASS: TestAccAWSElasticTranscoderPipeline_basic (90.51s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	90.599s

[bflad]

Thanks for updating this, @DrFaust92 🚀

Output from acceptance testing:

--- PASS: TestAccAWSElasticTranscoderPreset_disappears (5.70s)
--- PASS: TestAccAWSElasticTranscoderPreset_basic (18.29s)

[DrFaust92]

@bflad it looks like you ran the acceptance tests for my other elastic transcoder PR

[bflad]

Thanks 😓 I'll make sure this merge and the other are both fine before release.

[DrFaust92]

if it helps i rebased the other branch(+ removed the getStringPtr function) and it seems fine

[ghost]

This has been released in version 2.56.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!