-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/elastic_transcoder_pipeline - remove getStringPtr
calls + refactor tests
#12575
r/elastic_transcoder_pipeline - remove getStringPtr
calls + refactor tests
#12575
Conversation
refactor tests add disappearing test case
Verified acceptance tests: $ make testacc TEST=./aws TESTARGS='-run=TestAccAWSElasticTranscoderPipeline_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSElasticTranscoderPipeline_ -timeout 120m
=== RUN TestAccAWSElasticTranscoderPipeline_basic
=== PAUSE TestAccAWSElasticTranscoderPipeline_basic
=== RUN TestAccAWSElasticTranscoderPipeline_kmsKey
=== PAUSE TestAccAWSElasticTranscoderPipeline_kmsKey
=== RUN TestAccAWSElasticTranscoderPipeline_notifications
=== PAUSE TestAccAWSElasticTranscoderPipeline_notifications
=== RUN TestAccAWSElasticTranscoderPipeline_withContentConfig
=== PAUSE TestAccAWSElasticTranscoderPipeline_withContentConfig
=== RUN TestAccAWSElasticTranscoderPipeline_withPermissions
=== PAUSE TestAccAWSElasticTranscoderPipeline_withPermissions
=== RUN TestAccAWSElasticTranscoderPipeline_disappears
=== PAUSE TestAccAWSElasticTranscoderPipeline_disappears
=== CONT TestAccAWSElasticTranscoderPipeline_basic
=== CONT TestAccAWSElasticTranscoderPipeline_withPermissions
=== CONT TestAccAWSElasticTranscoderPipeline_disappears
=== CONT TestAccAWSElasticTranscoderPipeline_notifications
=== CONT TestAccAWSElasticTranscoderPipeline_withContentConfig
=== CONT TestAccAWSElasticTranscoderPipeline_kmsKey
--- PASS: TestAccAWSElasticTranscoderPipeline_disappears (38.15s)
--- PASS: TestAccAWSElasticTranscoderPipeline_withPermissions (47.10s)
--- PASS: TestAccAWSElasticTranscoderPipeline_kmsKey (62.83s)
--- PASS: TestAccAWSElasticTranscoderPipeline_notifications (67.19s)
--- PASS: TestAccAWSElasticTranscoderPipeline_withContentConfig (67.80s)
--- PASS: TestAccAWSElasticTranscoderPipeline_basic (90.51s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 90.599s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating this, @DrFaust92 🚀
Output from acceptance testing:
--- PASS: TestAccAWSElasticTranscoderPreset_disappears (5.70s)
--- PASS: TestAccAWSElasticTranscoderPreset_basic (18.29s)
@bflad it looks like you ran the acceptance tests for my other elastic transcoder PR |
Thanks 😓 I'll make sure this merge and the other are both fine before release. |
if it helps i rebased the other branch(+ removed the |
This has been released in version 2.56.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
refactor tests
add disappearing test case
Community Note
Relates #5983
Release note for CHANGELOG:
Output from acceptance testing: