Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rd/customer_gateway - add arn + validations #13611

Merged
merged 7 commits into from Jun 23, 2020
Merged

rd/customer_gateway - add arn + validations #13611

merged 7 commits into from Jun 23, 2020

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Jun 4, 2020 •
edited

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #13624, #13527

Release note for CHANGELOG:

resource_aws_customer_gateway : add arn attribute
resource_aws_customer_gateway : add validation to `bgp_asn`, `ip_address` and `type`
data_source_aws_customer_gateway : add arn attribute

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCustomerGateway_'
--- PASS: TestAccAWSCustomerGatewayDataSource_Filter (57.20s)
--- PASS: TestAccAWSCustomerGatewayDataSource_ID (54.76s)
--- PASS: TestAccAWSCustomerGateway_basic (92.61s)
--- PASS: TestAccAWSCustomerGateway_tags (103.05s)
--- PASS: TestAccAWSCustomerGateway_similarAlreadyExists (63.14s)
--- PASS: TestAccAWSCustomerGateway_disappears (42.18s)

@DrFaust92 DrFaust92 requested a review from a team June 4, 2020 12:54
@ghost ghost added size/L Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Jun 4, 2020
@ghost ghost added the provider Pertains to the provider itself, rather than any interaction with AWS. label Jun 4, 2020
bflad
bflad suggested changes Jun 17, 2020
View reviewed changes
Copy link
Member

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two little changes and should be good to go. 👍

aws/resource_aws_customer_gateway.go Outdated Show resolved Hide resolved
aws/resource_aws_customer_gateway.go Outdated Show resolved Hide resolved
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. waiting-response Maintainers are waiting on response from community or contributor. labels Jun 17, 2020
@bflad bflad self-assigned this Jun 17, 2020
@DrFaust92 @bflad
Apply suggestions from code review
40875c4 
if `bgp_asn` can be from 1 to 65534, should i change the tests as well to accommodate for this range?

Co-authored-by: Brian Flad <bflad417@gmail.com>
@DrFaust92 DrFaust92 requested a review from bflad June 17, 2020 21:12
@bflad bflad added this to the v2.68.0 milestone Jun 23, 2020
bflad
bflad approved these changes Jun 23, 2020
View reviewed changes
Copy link
Member

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Output from acceptance testing:

--- PASS: TestAccAWSCustomerGateway_basic (33.92s)
--- PASS: TestAccAWSCustomerGateway_disappears (17.29s)
--- PASS: TestAccAWSCustomerGateway_similarAlreadyExists (21.86s)
--- PASS: TestAccAWSCustomerGateway_tags (29.58s)

--- PASS: TestAccAWSCustomerGatewayDataSource_Filter (20.30s)
--- PASS: TestAccAWSCustomerGatewayDataSource_ID (19.81s)

@bflad bflad merged commit fe5c54f into hashicorp:master Jun 23, 2020
@DrFaust92 DrFaust92 deleted the r/customer_gateway-arn branch June 23, 2020 11:50
@ghost
Copy link

ghost commented Jun 26, 2020

This has been released in version 2.68.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@raxlarsbutler raxlarsbutler mentioned this pull request Jul 2, 2020
Closed
@ghost
Copy link

ghost commented Jul 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jul 23, 2020
@breathingdust breathingdust removed the waiting-response Maintainers are waiting on response from community or contributor. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.68.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DrFaust92 @bflad @breathingdust