aws_ami: Add root_snapshot_id attribute #1572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current limitations in HCL prevent it from being possible to reference an AMI's root snapshot ID via its ID. This is because the snapshot ID is deeply nested in the `block_device_mappings` set. HCL is not yet flexible enough to allow a lookup expression to extract the snapshot ID embedded within that structure. This makes it impossible to use resources like `aws_snapshot_create_volume_permission` without manually doing the AMI ID -> Snapshot ID translation outside of Terraform. Here, we promote the Snapshot ID of the root volume to a top-level `root_snapshot_id` attribute for AMI data sources and resources. This field will be blank for instance store AMIs or for weird conditions where there's no snapshot ID recorded (See commit message here: bed5f62), but it enables usage of the resource referenced above for the majority of scenarios.
phinze
added
the
enhancement
/cc @apparentlymart as we discussed this a bit |
radeksimko
approved these changes
Sep 4, 2017
| size = 8 | ||
| tags { | ||
| Name = "testAccAmiConfig_basic" | ||
| } |
There was a problem hiding this comment.
Nitpick - I think the convention is 2 spaces per indentation.
| size = 20 | ||
| tags { | ||
| Name = "testAccAmiConfig_snapshotSize" | ||
| } |
|
I'm not sure why did I point out the correct indentation as incorrect 🤔 Thanks for the PR. 👍 |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current limitations in HCL prevent it from being possible to reference
an AMI's root snapshot ID via its ID. This is because the snapshot ID is
deeply nested in the
block_device_mappingsset. HCL is notyet flexible enough to allow a lookup expression to extract the snapshot
ID embedded within that structure.
This makes it impossible to use resources like
aws_snapshot_create_volume_permissionwithout manually doing the AMIID -> Snapshot ID translation outside of Terraform.
Here, we promote the Snapshot ID of the root volume to a top-level
root_snapshot_idattribute for AMI data sources and resources.This field will be blank for instance store AMIs or for weird conditions
where there's no snapshot ID recorded (See commit message here:
bed5f62), but it enables usage of the
resource referenced above for the majority of scenarios.