Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added private_dns_name to network_interface #1599

Merged
merged 1 commit into from
Sep 7, 2017

Conversation

cosimomeli
Copy link

@cosimomeli cosimomeli commented Sep 6, 2017

I added the private_dns_name field to the aws_network_interface resource as I needed it.
Changed test cases to add DNS hostnames in VPCs.

TF_ACC=1 go test -v gitb.com/terraform-providers/terraform-provider-aws/aws -timeout=7200s -run "TestAccAWSENI_.*"
=== RUN   TestAccAWSENI_importBasic
--- PASS: TestAccAWSENI_importBasic (68.99s)
=== RUN   TestAccAWSENI_basic
--- PASS: TestAccAWSENI_basic (65.42s)
=== RUN   TestAccAWSENI_updatedDescription
--- PASS: TestAccAWSENI_updatedDescription (106.23s)
=== RUN   TestAccAWSENI_attached
--- PASS: TestAccAWSENI_attached (296.42s)
=== RUN   TestAccAWSENI_ignoreExternalAttachment
--- PASS: TestAccAWSENI_ignoreExternalAttachment (174.64s)
=== RUN   TestAccAWSENI_sourceDestCheck
--- PASS: TestAccAWSENI_sourceDestCheck (58.91s)
=== RUN   TestAccAWSENI_computedIPs
--- PASS: TestAccAWSENI_computedIPs (64.46s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	835.092s

@Ninir Ninir added the enhancement Requests to existing resources that expand the functionality or scope. label Sep 7, 2017
Copy link
Contributor

@Ninir Ninir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @cosimomeli

This looks very good to me for a first contribution! 👍

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSENI_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSENI_ -timeout 120m
=== RUN   TestAccAWSENI_importBasic
--- PASS: TestAccAWSENI_importBasic (157.48s)
=== RUN   TestAccAWSENI_basic
--- PASS: TestAccAWSENI_basic (160.02s)
=== RUN   TestAccAWSENI_updatedDescription
--- PASS: TestAccAWSENI_updatedDescription (247.85s)
=== RUN   TestAccAWSENI_attached
--- PASS: TestAccAWSENI_attached (427.12s)
=== RUN   TestAccAWSENI_ignoreExternalAttachment
--- PASS: TestAccAWSENI_ignoreExternalAttachment (287.33s)
=== RUN   TestAccAWSENI_sourceDestCheck
--- PASS: TestAccAWSENI_sourceDestCheck (122.42s)
=== RUN   TestAccAWSENI_computedIPs
--- PASS: TestAccAWSENI_computedIPs (120.85s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1523.102s

Thanks a lot!

@Ninir Ninir merged commit 490897d into hashicorp:master Sep 7, 2017
nbaztec pushed a commit to nbaztec/terraform-provider-aws that referenced this pull request Sep 26, 2017
Added private_dns_name to network_interface
@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants