Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_cognito_user_pool: Add computed arn attribute #2723

Merged
merged 1 commit into from
Dec 20, 2017
Merged

r/aws_cognito_user_pool: Add computed arn attribute #2723

merged 1 commit into from
Dec 20, 2017

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Dec 20, 2017

The API does not provide this directly, so let's synthesize it for now. Closes #2657

make testacc TEST=./aws TESTARGS='-run=TestAccAWSCognitoUserPool_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSCognitoUserPool_basic -timeout 120m
=== RUN   TestAccAWSCognitoUserPool_basic
--- PASS: TestAccAWSCognitoUserPool_basic (13.19s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	13.228s

@bflad bflad mentioned this pull request Dec 20, 2017
Closed
@jen20 jen20 added the enhancement Requests to existing resources that expand the functionality or scope. label Dec 20, 2017
jen20
jen20 approved these changes Dec 20, 2017
View reviewed changes
Copy link
Contributor

@jen20 jen20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bflad - this looks like a useful change!

@jen20 jen20 merged commit 518084a into hashicorp:master Dec 20, 2017
@bflad bflad deleted the cognito-user-pool-arn branch January 12, 2018 15:36
@bflad
Copy link
Contributor Author

bflad commented Jan 12, 2018

This has been released in terraform-provider-aws version 1.7.0. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@bflad bflad added this to the v1.7.0 milestone Jan 12, 2018
@ghost
Copy link

ghost commented Apr 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jen20 jen20 jen20 approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope.
Projects
None yet
Milestone
v1.7.0
Development

Successfully merging this pull request may close these issues.

aws_cognito_user_pool is missing arn attribute
2 participants
@bflad @jen20