Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: Bump jen20/awspolicyequivalence@9fbcaca9 #3832

Merged
merged 1 commit into from
Mar 20, 2018
Merged

deps: Bump jen20/awspolicyequivalence@9fbcaca9 #3832

merged 1 commit into from
Mar 20, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Mar 19, 2018 •
edited
Loading

govendor fetch github.com/jen20/awspolicyequivalence/...@9fbcaca9f9f868b9560463d0790aae33b2322945

Changes:

  • Handle AWS converting account ID principal to root IAM user ARN
  • Fix equality check for different use cases of empty respectively missing Principal trees which all have the same effect

Closes #286
Closes #596
Closes #719
Closes #720

@bflad
deps: Bump jen20/awspolicyequivalence@9fbcaca
534913b 
Changes:
* Handle AWS converting account ID principal to root IAM user ARN
* Fix equality check for different use cases of empty respectively missing Principal trees which all have the same effect
@bflad bflad added dependencies Used to indicate dependency changes. provider Pertains to the provider itself, rather than any interaction with AWS. labels Mar 19, 2018
@bflad bflad added this to the v1.12.0 milestone Mar 19, 2018
@ghost ghost added size/M Managed by automation to categorize the size of a PR. dependencies Used to indicate dependency changes. labels Mar 19, 2018
radeksimko
radeksimko approved these changes Mar 20, 2018
View reviewed changes
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of curiosity: Do we have any particular existing issue that we can/should close after merging this?

@bflad
Copy link
Contributor Author

bflad commented Mar 20, 2018

I'll need to do an exhaustive search here (there's quite a few related issues), but I might be hesitant to just close issues outright. Usually these fall under IAM policies showing a difference "unexpectedly" or "perpetually" which means different things for different people, but hopefully the account ID => IAM root ARN equivalence should squash a bunch of confusion though. That in particular stems from the AWS documentation showing it in a lot of places even though the API converts it afterwards.

@bflad
Copy link
Contributor Author

bflad commented Mar 20, 2018

I've attached 4 issues to close immediately because of this one on merge -- there are likely others though, its not easily searchable.

@bflad bflad merged commit 3d9d5f0 into master Mar 20, 2018
@bflad bflad deleted the v-awspolicyequivalence-9fbcaca9f9f868b9560463d0790aae33b2322945 branch March 20, 2018 12:19
This was referenced Mar 20, 2018
Closed
Closed
Closed
Closed
bflad added a commit that referenced this pull request Mar 20, 2018
@bflad
Update CHANGELOG for #3832
31fbf89
@bflad
Copy link
Contributor Author

bflad commented Mar 23, 2018

This has been released in version 1.12.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radeksimko radeksimko radeksimko approved these changes

Assignees
No one assigned
Labels
dependencies Used to indicate dependency changes. provider Pertains to the provider itself, rather than any interaction with AWS. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.12.0
2 participants
@bflad @radeksimko