Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data-source/lb_listener: set optional arguments as computed #4317

Merged
merged 1 commit into from
Apr 23, 2018
Merged

data-source/lb_listener: set optional arguments as computed #4317

merged 1 commit into from
Apr 23, 2018

Conversation

loivis
Copy link
Contributor

@loivis loivis commented Apr 23, 2018 •
edited
Loading

fix #4315

It's more of a misconfiguration on resource schema. Not sure if tests are needed here but added a few outputs to check optional arguments.

@ghost ghost added the size/S Managed by automation to categorize the size of a PR. label Apr 23, 2018
@bflad bflad added bug Addresses a defect in current functionality. service/elbv2 Issues and PRs that pertain to the elbv2 service. labels Apr 23, 2018
@bflad bflad added this to the v1.16.0 milestone Apr 23, 2018
bflad
bflad approved these changes Apr 23, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @loivis for the quick fix 😄 I'm sorry I missed this during the initial review -- definitely a subtle bug which the acceptance testing didn't make obvious. I'll have to think about that 🤔

@bflad bflad merged commit bd91f3a into hashicorp:master Apr 23, 2018
@loivis loivis deleted the ds-lb-listener branch April 23, 2018 19:14
@bflad bflad mentioned this pull request Apr 23, 2018
Closed
@loivis
Copy link
Contributor Author

loivis commented Apr 23, 2018

It's good for me though. I'll now remember it much better as I made mistake here 😆

bflad added a commit that referenced this pull request Apr 23, 2018
@bflad
Update CHANGELOG for #4317
53866e2
@bflad
Copy link
Contributor

bflad commented Apr 25, 2018

This has been released in version 1.16.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. service/elbv2 Issues and PRs that pertain to the elbv2 service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.16.0
Development

Successfully merging this pull request may close these issues.

Unable to access 'load_balancer_arn' property from 'aws_lb_listener' data query
2 participants
@loivis @bflad