issue #5440 terraform crash in resource elasticsearch_domain

[saravanan30erd]

Fixes #5440

Changes proposed in this pull request:

• Change 1
  fixed panic nil pointer dereference error.
• Change 2
  Properly dereferenced other attributes too.

[bflad]

This d.Set() was incorrectly implemented before (notice the missing [] before the map) and we should probably fix it now. I think the AutomatedSnapshotStartHour value also needs to be wrapped in int(). Something like the below could handle both for now and return an error if incorrect:

if err := d.Set("snapshot_options", flattenESSnapshotOptions(ds.SnapshotOptions)); err != nil {
	return fmt.Errorf("error setting snapshot_options: %s": err)
}

func flattenESSnapshotOptions(snapshotOptions *elasticsearch.SnapshotOptions) []map[string]interface{} {
	if snapshotOptions == nil {
		return []map[string]interface{}{}
	}

	m := map[string]interface{}{
		"automated_snapshot_start_hour": int(aws.Int64Value(snapshotOptions.AutomatedSnapshotStartHour)),
	}

	return []map[string]interface{}{m}
}

[saravanan30erd]

@bflad Done 👍

[bflad]

Looks like one more little thing if you have a chance, since we actually fixed the "container" snapshot_options attribute, its reporting a difference if its not defined in the configuration:

=== RUN   TestAccAWSElasticSearchDomain_basic
--- FAIL: TestAccAWSElasticSearchDomain_basic (1214.92s)
	testing.go:518: Step 0 error: After applying this step, the plan was not empty:
		
		DIFF:
		
		UPDATE: aws_elasticsearch_domain.example
		  snapshot_options.#: "1" => "0"

It should be okay if we tell the schema to ignore this difference as the underlying attributes are what really matter in this case. 👍

// In "snapshot_options" attribute definition:
DiffSuppressFunc: func(k, old, new string, d *schema.ResourceData) bool {
	if old == "1" && new == "0" {
		return true
	}
	return false
},

Thanks so much!

[saravanan30erd]

@bflad I added diffsuppress func. I think if we check the nil value for SnapshotOptions before setting it like below, we can prevent this issue right?

if ds.SnapshotOptions != nil {
    if err := d.Set("snapshot_options", flattenESSnapshotOptions(ds.SnapshotOptions)); err != nil {
	        return fmt.Errorf("error setting snapshot_options: %s", err)
    }
}

[bflad]

Thanks @saravanan30erd! LGTM 🚀

(Test failures unrelated)

=== RUN   TestAccAWSElasticSearchDomain_duplicate
--- FAIL: TestAccAWSElasticSearchDomain_duplicate (551.56s)
=== RUN   TestAccAWSElasticSearchDomain_encrypt_at_rest_specify_key
--- PASS: TestAccAWSElasticSearchDomain_encrypt_at_rest_specify_key (787.75s)
=== RUN   TestAccAWSElasticSearchDomain_policy
--- PASS: TestAccAWSElasticSearchDomain_policy (820.13s)
=== RUN   TestAccAWSElasticSearchDomain_importBasic
--- PASS: TestAccAWSElasticSearchDomain_importBasic (1017.47s)
=== RUN   TestAccAWSElasticSearchDomain_v23
--- PASS: TestAccAWSElasticSearchDomain_v23 (1040.20s)
=== RUN   TestAccAWSElasticSearchDomain_basic
--- PASS: TestAccAWSElasticSearchDomain_basic (1054.86s)
=== RUN   TestAccAWSElasticSearchDomain_complex
--- PASS: TestAccAWSElasticSearchDomain_complex (1162.99s)
=== RUN   TestAccAWSElasticSearchDomain_encrypt_at_rest_default_key
--- PASS: TestAccAWSElasticSearchDomain_encrypt_at_rest_default_key (1265.94s)
=== RUN   TestAccAWSElasticSearchDomainPolicy_basic
--- PASS: TestAccAWSElasticSearchDomainPolicy_basic (1355.98s)
=== RUN   TestAccAWSElasticSearchDomain_vpc
--- PASS: TestAccAWSElasticSearchDomain_vpc (1366.21s)
=== RUN   TestAccAWSElasticSearchDomain_CognitoOptionsCreateAndRemove
--- PASS: TestAccAWSElasticSearchDomain_CognitoOptionsCreateAndRemove (1405.46s)
=== RUN   TestAccAWSElasticSearchDomain_tags
--- PASS: TestAccAWSElasticSearchDomain_tags (1471.90s)
=== RUN   TestAccAWSElasticSearchDomain_CognitoOptionsUpdate
--- PASS: TestAccAWSElasticSearchDomain_CognitoOptionsUpdate (1529.72s)
=== RUN   TestAccAWSElasticSearchDomain_LogPublishingOptions
--- PASS: TestAccAWSElasticSearchDomain_LogPublishingOptions (1655.18s)
=== RUN   TestAccAWSElasticSearchDomain_update
--- PASS: TestAccAWSElasticSearchDomain_update (2038.16s)
=== RUN   TestAccAWSElasticSearchDomain_vpc_update
--- PASS: TestAccAWSElasticSearchDomain_vpc_update (2267.89s)
=== RUN   TestAccAWSElasticSearchDomain_internetToVpcEndpoint
--- PASS: TestAccAWSElasticSearchDomain_internetToVpcEndpoint (2451.08s)
=== RUN   TestAccAWSElasticSearchDomain_update_volume_type
--- FAIL: TestAccAWSElasticSearchDomain_update_volume_type (5347.53s)

[bflad]

This has been released in version 1.31.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!