Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/launch_template: fix setting ipv6_addresses #5883

Merged
merged 1 commit into from
Sep 16, 2018

Conversation

kl4w
Copy link
Contributor

@kl4w kl4w commented Sep 14, 2018

Fixes #5863

Changes proposed in this pull request:

  • fix setting ipv6_addresses

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSLaunchTemplate_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSLaunchTemplate_ -timeout 120m
=== RUN   TestAccAWSLaunchTemplate_importBasic
--- PASS: TestAccAWSLaunchTemplate_importBasic (13.90s)
=== RUN   TestAccAWSLaunchTemplate_importData
--- PASS: TestAccAWSLaunchTemplate_importData (11.87s)
=== RUN   TestAccAWSLaunchTemplate_basic
--- PASS: TestAccAWSLaunchTemplate_basic (12.15s)
=== RUN   TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS (48.40s)
=== RUN   TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_DeleteOnTermination
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_DeleteOnTermination (48.53s)
=== RUN   TestAccAWSLaunchTemplate_data
--- PASS: TestAccAWSLaunchTemplate_data (12.43s)
=== RUN   TestAccAWSLaunchTemplate_update
--- PASS: TestAccAWSLaunchTemplate_update (47.38s)
=== RUN   TestAccAWSLaunchTemplate_tags
--- PASS: TestAccAWSLaunchTemplate_tags (20.51s)
=== RUN   TestAccAWSLaunchTemplate_nonBurstable
--- PASS: TestAccAWSLaunchTemplate_nonBurstable (11.83s)
=== RUN   TestAccAWSLaunchTemplate_networkInterface
--- PASS: TestAccAWSLaunchTemplate_networkInterface (29.74s)
=== RUN   TestAccAWSLaunchTemplate_networkInterface_ipv6Addresses
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6Addresses (10.59s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	267.359s

@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label Sep 14, 2018
@bflad bflad added bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service. labels Sep 14, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6Addresses (4.38s)
--- PASS: TestAccAWSLaunchTemplate_nonBurstable (4.58s)
--- PASS: TestAccAWSLaunchTemplate_data (4.77s)
--- PASS: TestAccAWSLaunchTemplate_importData (4.89s)
--- PASS: TestAccAWSLaunchTemplate_basic (4.97s)
--- PASS: TestAccAWSLaunchTemplate_importBasic (5.38s)
--- PASS: TestAccAWSLaunchTemplate_tags (12.76s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface (14.18s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS (39.33s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_DeleteOnTermination (41.22s)
--- PASS: TestAccAWSLaunchTemplate_update (48.51s)

@bflad bflad added this to the v1.37.0 milestone Sep 16, 2018
@bflad bflad merged commit 5bb3823 into hashicorp:master Sep 16, 2018
bflad added a commit that referenced this pull request Sep 16, 2018
@kl4w kl4w deleted the launch-template-ipv6-addresses branch September 17, 2018 17:32
@bflad
Copy link
Contributor

bflad commented Sep 19, 2018

This has been released in version 1.37.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_launch_template: ipv6_addresses not set correctly
2 participants