Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource: aws_glacier_vault_lock #6432

Merged
merged 1 commit into from
Nov 12, 2018
Merged

New Resource: aws_glacier_vault_lock #6432

merged 1 commit into from
Nov 12, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Nov 11, 2018

This resource is a little odd because it can only be "destroyed" when in a testing mode (e.g. before the lock is completed). We provide a ignore_deletion_error argument to workaround cases of deleting/recreating the Glacier Vault.

Output from acceptance testing:

--- PASS: TestAccAWSGlacierVaultLock_basic (18.63s)
--- PASS: TestAccAWSGlacierVaultLock_CompleteLock (19.02s)

@bflad
New Resource: aws_glacier_vault_lock
3e6c082 
```
--- PASS: TestAccAWSGlacierVaultLock_basic (18.63s)
--- PASS: TestAccAWSGlacierVaultLock_CompleteLock (19.02s)
```
@bflad bflad added new-resource Introduces a new resource. service/glacier Issues and PRs that pertain to the glacier service. labels Nov 11, 2018
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 11, 2018
@bflad bflad requested a review from a team November 12, 2018 13:54
mbfrahry
mbfrahry approved these changes Nov 12, 2018
View reviewed changes
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bflad bflad added this to the v1.44.0 milestone Nov 12, 2018
@bflad bflad merged commit 36310a2 into master Nov 12, 2018
@bflad bflad deleted the f-aws_glacier_vault_lock_policy branch November 12, 2018 17:12
bflad added a commit that referenced this pull request Nov 12, 2018
@bflad
Update CHANGELOG for #6432
21ace26
@bflad
Copy link
Contributor Author

bflad commented Nov 15, 2018

This has been released in version 1.44.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@mdlavin mdlavin mentioned this pull request Nov 21, 2018
Closed
@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mbfrahry mbfrahry mbfrahry approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/glacier Issues and PRs that pertain to the glacier service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v1.44.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bflad @mbfrahry