Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Support disabling delation of RDS automated backups #6507

Closed
nathanielks opened this issue Nov 16, 2018 · 6 comments · Fixed by #8461
Closed

Feature: Support disabling delation of RDS automated backups #6507

nathanielks opened this issue Nov 16, 2018 · 6 comments · Fixed by #8461
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service.
Milestone

Comments

@nathanielks
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

In a recent announcement, AWS said you can now save RDS backups after the instance itself has been deleted. This behavior is opt-in and needs to have support for it in Terraform.

New or Affected Resource(s)

  • aws_db_instance

Potential Terraform Configuration

resource "aws_db_instance" "main" {

  delete_automated_backups = false
  // Additional config...
}

References

N/A

@sunilkumarmohanty
Copy link
Contributor

I think aws sdk for go does not support this feature yet.

@nathanielks
Copy link
Contributor Author

After looking at https://github.com/aws/aws-sdk-go/blob/f26268b77ea9619d95b1d04b6f3e3c5a03b61110/service/rds/api.go, I agree! We'll have to wait for that to be rolled out, then.

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service. labels Nov 19, 2018
@bflad bflad added this to the v2.49.0 milestone Feb 11, 2020
@bflad bflad self-assigned this Feb 11, 2020
@bflad
Copy link
Member

bflad commented Feb 11, 2020

Support for this functionality has been merged and will release with version 2.49.0 of the Terraform AWS Provider, Thursday this week. Thanks to @MrLunar for the implementation. 👍

@alex
Copy link
Contributor

alex commented Feb 13, 2020

Huge thanks to both you and @MrLunar for bringing this to completion!

@ghost
Copy link

ghost commented Feb 14, 2020

This has been released in version 2.49.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service.
Projects
None yet
4 participants