Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_rds_cluster_parameter_group: Prevent missing DBClusterParameterGroupName error on creation with generated names and name_prefix #7326

Merged
merged 1 commit into from
Jan 25, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jan 25, 2019

Fixes #1739
Fixes #7264

Previous output from acceptance testing:

--- FAIL: TestAccAWSDBClusterParameterGroup_generatedName_Parameter (8.30s)
    testing.go:538: Step 0 error: Error applying: 1 error occurred:
        	* aws_rds_cluster_parameter_group.test: 1 error occurred:
        	* aws_rds_cluster_parameter_group.test: Error modifying DB Cluster Parameter Group: InvalidParameterValue: The parameter DBClusterParameterGroupName must be provided and must not be blank.
        	status code: 400, request id: e2a07ba0-ba60-4d24-a8ee-3d7a86cf1793

--- FAIL: TestAccAWSDBClusterParameterGroup_namePrefix_Parameter (8.43s)
    testing.go:538: Step 0 error: Error applying: 1 error occurred:
        	* aws_rds_cluster_parameter_group.test: 1 error occurred:
        	* aws_rds_cluster_parameter_group.test: Error modifying DB Cluster Parameter Group: InvalidParameterValue: The parameter DBClusterParameterGroupName must be provided and must not be blank.
        	status code: 400, request id: 895b9f34-c88e-46ec-8006-0ee61096cff1

Output from acceptance testing:

--- PASS: TestAccAWSDBClusterParameterGroup_disappears (10.98s)
--- PASS: TestAccAWSDBClusterParameterGroup_namePrefix (12.80s)
--- PASS: TestAccAWSDBClusterParameterGroup_generatedName (12.99s)
--- PASS: TestAccAWSDBClusterParameterGroup_namePrefix_Parameter (13.53s)
--- PASS: TestAccAWSDBClusterParameterGroup_generatedName_Parameter (13.60s)
--- PASS: TestAccAWSDBClusterParameterGroup_withApplyMethod (14.34s)
--- PASS: TestAccAWSDBClusterParameterGroup_importBasic (15.56s)
--- PASS: TestAccAWSDBClusterParameterGroup_basic (24.07s)

…rameterGroupName error on creation with generated names and name_prefix

References:
* #1739
* #7264

Previous output from acceptance testing:

```
--- FAIL: TestAccAWSDBClusterParameterGroup_generatedName_Parameter (8.30s)
    testing.go:538: Step 0 error: Error applying: 1 error occurred:
        	* aws_rds_cluster_parameter_group.test: 1 error occurred:
        	* aws_rds_cluster_parameter_group.test: Error modifying DB Cluster Parameter Group: InvalidParameterValue: The parameter DBClusterParameterGroupName must be provided and must not be blank.
        	status code: 400, request id: e2a07ba0-ba60-4d24-a8ee-3d7a86cf1793

--- FAIL: TestAccAWSDBClusterParameterGroup_namePrefix_Parameter (8.43s)
    testing.go:538: Step 0 error: Error applying: 1 error occurred:
        	* aws_rds_cluster_parameter_group.test: 1 error occurred:
        	* aws_rds_cluster_parameter_group.test: Error modifying DB Cluster Parameter Group: InvalidParameterValue: The parameter DBClusterParameterGroupName must be provided and must not be blank.
        	status code: 400, request id: 895b9f34-c88e-46ec-8006-0ee61096cff1
```

Output from acceptance testing:

```
--- PASS: TestAccAWSDBClusterParameterGroup_disappears (10.98s)
--- PASS: TestAccAWSDBClusterParameterGroup_namePrefix (12.80s)
--- PASS: TestAccAWSDBClusterParameterGroup_generatedName (12.99s)
--- PASS: TestAccAWSDBClusterParameterGroup_namePrefix_Parameter (13.53s)
--- PASS: TestAccAWSDBClusterParameterGroup_generatedName_Parameter (13.60s)
--- PASS: TestAccAWSDBClusterParameterGroup_withApplyMethod (14.34s)
--- PASS: TestAccAWSDBClusterParameterGroup_importBasic (15.56s)
--- PASS: TestAccAWSDBClusterParameterGroup_basic (24.07s)
```
@bflad bflad added bug Addresses a defect in current functionality. service/rds Issues and PRs that pertain to the rds service. labels Jan 25, 2019
@bflad bflad requested a review from a team January 25, 2019 08:16
@ghost ghost added size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 25, 2019
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bflad bflad added this to the v1.57.0 milestone Jan 25, 2019
@bflad bflad merged commit 92ce64d into master Jan 25, 2019
@bflad bflad deleted the b-aws_rds_cluster_parameter_group-use-id-in-update branch January 25, 2019 15:17
bflad added a commit that referenced this pull request Jan 25, 2019
bflad added a commit that referenced this pull request Jan 25, 2019
@bflad
Copy link
Contributor Author

bflad commented Jan 26, 2019

This has been released in version 1.57.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/rds Issues and PRs that pertain to the rds service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
2 participants