Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_lb_target_group: Add lambda_multi_value_headers_enabled argument #7648

Merged
merged 1 commit into from
Mar 1, 2019
Merged

resource/aws_lb_target_group: Add lambda_multi_value_headers_enabled argument #7648

merged 1 commit into from
Mar 1, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Feb 22, 2019

Closes #7637

Output from acceptance testing:

--- PASS: TestAccAWSALBTargetGroup_lambda (13.37s)
--- PASS: TestAccAWSALBTargetGroup_missingPortProtocolVpc (17.64s)
--- PASS: TestAccAWSALBTargetGroup_namePrefix (23.80s)
--- PASS: TestAccAWSALBTargetGroup_generatedName (24.12s)
--- PASS: TestAccAWSALBTargetGroup_basic (24.63s)
--- PASS: TestAccAWSALBTargetGroup_lambdaMultiValueHeadersEnabled (30.06s)
--- PASS: TestAccAWSALBTargetGroup_setAndUpdateSlowStart (39.47s)
--- PASS: TestAccAWSALBTargetGroup_tags (40.23s)
--- PASS: TestAccAWSALBTargetGroup_changeNameForceNew (41.56s)
--- PASS: TestAccAWSALBTargetGroup_changePortForceNew (41.67s)
--- PASS: TestAccAWSALBTargetGroup_changeVpcForceNew (43.88s)
--- PASS: TestAccAWSALBTargetGroup_updateHealthCheck (46.08s)
--- PASS: TestAccAWSALBTargetGroup_changeProtocolForceNew (52.34s)
--- PASS: TestAccAWSALBTargetGroup_updateSticknessEnabled (55.45s)

@bflad
resource/aws_lb_target_group: Add lambda_multi_value_headers_enabled …
03849bc 
…argument

Reference: #7637

Output from acceptance testing:

```
--- PASS: TestAccAWSALBTargetGroup_lambda (13.37s)
--- PASS: TestAccAWSALBTargetGroup_missingPortProtocolVpc (17.64s)
--- PASS: TestAccAWSALBTargetGroup_namePrefix (23.80s)
--- PASS: TestAccAWSALBTargetGroup_generatedName (24.12s)
--- PASS: TestAccAWSALBTargetGroup_basic (24.63s)
--- PASS: TestAccAWSALBTargetGroup_lambdaMultiValueHeadersEnabled (30.06s)
--- PASS: TestAccAWSALBTargetGroup_setAndUpdateSlowStart (39.47s)
--- PASS: TestAccAWSALBTargetGroup_tags (40.23s)
--- PASS: TestAccAWSALBTargetGroup_changeNameForceNew (41.56s)
--- PASS: TestAccAWSALBTargetGroup_changePortForceNew (41.67s)
--- PASS: TestAccAWSALBTargetGroup_changeVpcForceNew (43.88s)
--- PASS: TestAccAWSALBTargetGroup_updateHealthCheck (46.08s)
--- PASS: TestAccAWSALBTargetGroup_changeProtocolForceNew (52.34s)
--- PASS: TestAccAWSALBTargetGroup_updateSticknessEnabled (55.45s)
```
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/elbv2 Issues and PRs that pertain to the elbv2 service. labels Feb 22, 2019
@bflad bflad requested a review from a team February 22, 2019 03:02
@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 22, 2019
@bflad bflad mentioned this pull request Feb 22, 2019
Closed
@bflad bflad modified the milestones: v2.2.0, v2.1.0 Feb 28, 2019
@bflad bflad merged commit 61e980e into master Mar 1, 2019
@bflad bflad deleted the f-aws_lb_target_group-lambda_multi_value_headers_enabled branch March 1, 2019 19:47
bflad added a commit that referenced this pull request Mar 1, 2019
@bflad
Update CHANGELOG for #7648
dc27d44
@bflad
Copy link
Contributor Author

bflad commented Mar 8, 2019

This has been released in version 2.1.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paddycarver paddycarver paddycarver approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/elbv2 Issues and PRs that pertain to the elbv2 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging this pull request may close these issues.

Allow enabling/disabling the 'multi-header' attribute on a lambda target group
2 participants
@bflad @paddycarver