Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add engine_version to modify option at restore from snapshot step #7738

Conversation

teraken0509
Copy link
Contributor

Fixes #7723

Changes proposed in this pull request:

  • Add setting engine_version to modify options when creating from snapshot restore

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSDBInstance_MySQL_SnapshotRestoreWithEngineVersion'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSDBInstance_MySQL_SnapshotRestoreWithEngineVersion -timeout 120m
=== RUN   TestAccAWSDBInstance_MySQL_SnapshotRestoreWithEngineVersion
=== PAUSE TestAccAWSDBInstance_MySQL_SnapshotRestoreWithEngineVersion
=== CONT  TestAccAWSDBInstance_MySQL_SnapshotRestoreWithEngineVersion
--- PASS: TestAccAWSDBInstance_MySQL_SnapshotRestoreWithEngineVersion (1929.94s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1930.005s

@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 27, 2019
@bflad bflad added the bug Addresses a defect in current functionality. label Mar 3, 2019
@bflad bflad added this to the v2.1.0 milestone Mar 3, 2019
Copy link
Member

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks so much @kterada0509 🚀

New acceptance test before code update:

--- FAIL: TestAccAWSDBInstance_MySQL_SnapshotRestoreWithEngineVersion (1388.58s)
    testing.go:538: Step 0 error: Check failed: Check 4/4 error: aws_db_instance.mysql_restore: Attribute 'engine_version' expected "5.6.41", got "5.6.35"

Acceptance test after code update:

--- PASS: TestAccAWSDBInstance_MySQL_SnapshotRestoreWithEngineVersion (1893.36s)

@bflad bflad merged commit 3e6a4f6 into hashicorp:master Mar 4, 2019
bflad added a commit that referenced this pull request Mar 4, 2019
bflad added a commit that referenced this pull request Mar 4, 2019
bflad added a commit that referenced this pull request Mar 4, 2019
@bflad
Copy link
Member

bflad commented Mar 8, 2019

This has been released in version 2.1.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@teraken0509 teraken0509 deleted the feature/add-engine_version-support-for-restore-from-snapshot branch March 5, 2020 14:01
@ghost
Copy link

ghost commented Mar 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/rds Issues and PRs that pertain to the rds service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RDS snapshot restore ignores specified engine_version
2 participants