Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDS snapshot restore ignores specified engine_version #7723

Closed
maxleonca opened this issue Feb 25, 2019 · 3 comments · Fixed by #7738
Closed

RDS snapshot restore ignores specified engine_version #7723

maxleonca opened this issue Feb 25, 2019 · 3 comments · Fixed by #7738
Labels
bug Addresses a defect in current functionality. service/rds Issues and PRs that pertain to the rds service.
Milestone

Comments

@maxleonca
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version

0.11.11

aws provider version 1.59.0

Affected Resource(s)

RDS Postgres instance

Terraform Configuration Files

data "aws_db_snapshot" "db_prod_snapshot" {
    most_recent = true
    db_instance_identifier = "production"
}

resource "aws_db_instance" "staging_db" {
    identifier = "staging-vpc"

    snapshot_identifier = "${data.aws_db_snapshot.db_prod_snapshot.id}"
    skip_final_snapshot = true
    instance_class = "${var.db_instance_class}"
    auto_minor_version_upgrade = true
    engine_version = "9.4.20"
    apply_immediately = true

    db_subnet_group_name = "${var.db_subnet_group}"
    vpc_security_group_ids = "${var.rds_security_groups}"

    backup_retention_period = 0

    tags {
    }
}
  

Debug Output

https://gist.github.com/maxleonca/c242d786da61cb9df643be120725c90b

Panic Output

none

Expected Behavior

The new engine version specified in the code should have been applied to the restored snapshot

Actual Behavior

The specified engine version is ignored and the one that was on the original DB from where the snapshot was taken is enforced during the restoration process.

Steps to Reproduce

Import a snapshot and change the engine version.

  1. terraform apply

Important Factoids

References

@nywilken nywilken added service/rds Issues and PRs that pertain to the rds service. bug Addresses a defect in current functionality. labels Feb 26, 2019
@bflad bflad added this to the v2.1.0 milestone Mar 3, 2019
@bflad
Copy link
Contributor

bflad commented Mar 4, 2019

The fix for this has been merged and will release with version 2.1.0 of the Terraform AWS Provider, likely middle of this week.

@bflad
Copy link
Contributor

bflad commented Mar 8, 2019

This has been released in version 2.1.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/rds Issues and PRs that pertain to the rds service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants