Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support import for aws_appautoscaling_policy and aws_appautoscaling_target #8032

Conversation

katainaka0503
Copy link
Contributor

@katainaka0503 katainaka0503 commented Mar 21, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Changes proposed in this pull request:

  • Support import for aws_appautoscaling_policy
  • Support import for aws_appautoscaling_target

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppautoScalingPolicy'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSAppautoScalingPolicy -timeout 120m
=== RUN   TestAccAWSAppautoScalingPolicy_basic
=== PAUSE TestAccAWSAppautoScalingPolicy_basic
=== RUN   TestAccAWSAppautoScalingPolicy_disappears
=== PAUSE TestAccAWSAppautoScalingPolicy_disappears
=== RUN   TestAccAWSAppautoScalingPolicy_scaleOutAndIn
=== PAUSE TestAccAWSAppautoScalingPolicy_scaleOutAndIn
=== RUN   TestAccAWSAppautoScalingPolicy_spotFleetRequest
=== PAUSE TestAccAWSAppautoScalingPolicy_spotFleetRequest
=== RUN   TestAccAWSAppautoScalingPolicy_dynamoDb
=== PAUSE TestAccAWSAppautoScalingPolicy_dynamoDb
=== RUN   TestAccAWSAppautoScalingPolicy_multiplePoliciesSameName
=== PAUSE TestAccAWSAppautoScalingPolicy_multiplePoliciesSameName
=== RUN   TestAccAWSAppautoScalingPolicy_multiplePoliciesSameResource
=== PAUSE TestAccAWSAppautoScalingPolicy_multiplePoliciesSameResource
=== RUN   TestAccAWSAppautoScalingPolicy_ResourceId_ForceNew
=== PAUSE TestAccAWSAppautoScalingPolicy_ResourceId_ForceNew
=== CONT  TestAccAWSAppautoScalingPolicy_basic
=== CONT  TestAccAWSAppautoScalingPolicy_ResourceId_ForceNew
=== CONT  TestAccAWSAppautoScalingPolicy_multiplePoliciesSameResource
=== CONT  TestAccAWSAppautoScalingPolicy_multiplePoliciesSameName
=== CONT  TestAccAWSAppautoScalingPolicy_dynamoDb
=== CONT  TestAccAWSAppautoScalingPolicy_spotFleetRequest
=== CONT  TestAccAWSAppautoScalingPolicy_scaleOutAndIn
=== CONT  TestAccAWSAppautoScalingPolicy_disappears
--- PASS: TestAccAWSAppautoScalingPolicy_disappears (41.66s)
--- PASS: TestAccAWSAppautoScalingPolicy_scaleOutAndIn (52.17s)
--- PASS: TestAccAWSAppautoScalingPolicy_basic (52.72s)
--- PASS: TestAccAWSAppautoScalingPolicy_ResourceId_ForceNew (86.29s)
--- PASS: TestAccAWSAppautoScalingPolicy_spotFleetRequest (86.67s)
--- PASS: TestAccAWSAppautoScalingPolicy_dynamoDb (141.87s)
--- PASS: TestAccAWSAppautoScalingPolicy_multiplePoliciesSameName (141.93s)
--- PASS: TestAccAWSAppautoScalingPolicy_multiplePoliciesSameResource (145.59s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       145.646s
$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppautoScalingTarget'      
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSAppautoScalingTarget -timeout 120m
=== RUN   TestAccAWSAppautoScalingTarget_basic
=== PAUSE TestAccAWSAppautoScalingTarget_basic
=== RUN   TestAccAWSAppautoScalingTarget_spotFleetRequest
=== PAUSE TestAccAWSAppautoScalingTarget_spotFleetRequest
=== RUN   TestAccAWSAppautoScalingTarget_emrCluster
=== PAUSE TestAccAWSAppautoScalingTarget_emrCluster
=== RUN   TestAccAWSAppautoScalingTarget_multipleTargets
=== PAUSE TestAccAWSAppautoScalingTarget_multipleTargets
=== RUN   TestAccAWSAppautoScalingTarget_optionalRoleArn
=== PAUSE TestAccAWSAppautoScalingTarget_optionalRoleArn
=== CONT  TestAccAWSAppautoScalingTarget_basic
=== CONT  TestAccAWSAppautoScalingTarget_spotFleetRequest
=== CONT  TestAccAWSAppautoScalingTarget_emrCluster
=== CONT  TestAccAWSAppautoScalingTarget_multipleTargets
=== CONT  TestAccAWSAppautoScalingTarget_optionalRoleArn
--- PASS: TestAccAWSAppautoScalingTarget_basic (79.44s)
--- PASS: TestAccAWSAppautoScalingTarget_spotFleetRequest (90.14s)
--- PASS: TestAccAWSAppautoScalingTarget_optionalRoleArn (135.78s)
--- PASS: TestAccAWSAppautoScalingTarget_multipleTargets (137.16s)
--- PASS: TestAccAWSAppautoScalingTarget_emrCluster (550.01s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       550.081s

@ghost ghost added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/applicationautoscaling tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 21, 2019
@katainaka0503 katainaka0503 force-pushed the feature/add-support-appautoscaling-policy-and-target-import branch from 32b9a7d to 1ce1279 Compare March 21, 2019 09:44
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Mar 21, 2019
@bflad bflad added this to the v2.3.0 milestone Mar 21, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @katainaka0503! 🚀

--- PASS: TestAccAWSAppautoScalingPolicy_basic (49.16s)
--- PASS: TestAccAWSAppautoScalingPolicy_disappears (37.14s)
--- PASS: TestAccAWSAppautoScalingPolicy_dynamoDb (116.42s)
--- PASS: TestAccAWSAppautoScalingPolicy_multiplePoliciesSameName (117.24s)
--- PASS: TestAccAWSAppautoScalingPolicy_multiplePoliciesSameResource (119.68s)
--- PASS: TestAccAWSAppautoScalingPolicy_ResourceId_ForceNew (43.38s)
--- PASS: TestAccAWSAppautoScalingPolicy_scaleOutAndIn (40.85s)
--- PASS: TestAccAWSAppautoScalingPolicy_spotFleetRequest (62.36s)

--- PASS: TestAccAWSAppautoScalingTarget_basic (40.82s)
--- PASS: TestAccAWSAppautoScalingTarget_emrCluster (468.94s)
--- PASS: TestAccAWSAppautoScalingTarget_multipleTargets (112.13s)
--- PASS: TestAccAWSAppautoScalingTarget_optionalRoleArn (111.72s)
--- PASS: TestAccAWSAppautoScalingTarget_spotFleetRequest (58.84s)

@bflad bflad merged commit f25ae3d into hashicorp:master Mar 21, 2019
bflad added a commit that referenced this pull request Mar 21, 2019
@bflad
Copy link
Contributor

bflad commented Mar 21, 2019

This has been released in version 2.3.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@katainaka0503 katainaka0503 deleted the feature/add-support-appautoscaling-policy-and-target-import branch March 22, 2019 00:28
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants